Disable the "eye" icon on the login page

[nono-gdv]

In our context, the "show password" icon on the login page is a security risk. Basically, our users have the same password for ownCloud as for all of our systems (we use LDAP for authentication) and we don't want to allow this password to be displayed "by accident" (I know we can't prevent people from giving away their passwords but that's another issue entirely).

So, after reading http://forum.owncloud.org/viewtopic.php?t=9198 I wrote a patch to disable it. The patch is available online: https://pchit.ircam.fr/public.php?service=files&t=7701086681410079d4783980a772fffa

I'm familiar neither with PHP nor wit the ownCloud codebase, so I'm not sure this qualifies as "clean", but it works for me. :-)

[nono-gdv]

Forgot the version info: the patch is against version 5.0.10.

[karlitschek]

Please submit this as a pull request on github. You should also sign the contributor agreement if this should go into core or you can release your changes under the MIT license. https://owncloud.org/about/contributor-agreement/

@jancborchardt @LukasReschke @DeepDiver1975 Do you think it makes sense to have this feature configurable via the config.php ? I'm unsure.

[DeepDiver1975]

In order to not drive deeper into the configuration nightmare I'd say: no

But I see the risk.

What about going the windows 8 way:
The eye is not toggling but only on mouse button down the password is shown. As soon as the mouse button is released the password is hidden again.

This should work on touch screens as well

[nono-gdv]

I submitted a pull request: #4580

I will send you the contributor agreement as soon as I get formal approval from my employer.

[jancborchardt]

Superseded by #4610, please review. :)