Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent updates between multiple major versions #11163

Merged
merged 1 commit into from Sep 19, 2014

Conversation

@LukasReschke
Copy link
Member

commented Sep 18, 2014

Testplan:

  • Increment version in version.php for 1 major release => Update works
  • Increment version in version.php for 2 major releases => Update does not work

Ref #11078

@LukasReschke LukasReschke force-pushed the check-for-updates-between-major-versions branch 2 times, most recently Sep 18, 2014
@LukasReschke LukasReschke force-pushed the check-for-updates-between-major-versions branch to a71af58 Sep 18, 2014
@scrutinizer-notifier

This comment has been minimized.

Copy link

commented Sep 18, 2014

A new inspection was created.

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

occ upgrade does not yet behave correctly, see #11165

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

To clarify: oCC shows the error and that the upgrade has succeeded. Despite the success message no upgrade is performed.

@ghost

This comment has been minimized.

Copy link

commented Sep 18, 2014

💣 Test Failed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org/job/pull-request-analyser/7464/

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

@owncloud-bot Retest this please

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

👍 looks good - for sure worth backporting down to stable5

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

We need to backport this only to stable7 due to the nature of the upgrade process. It includes overwriting all files and then the upgrade script is called.

This means if you install ownCloud 7 over a ownCloud 5 installation this script will already be there. And ownCloud 5 to 6 is something what we support :-)

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2014

@karlitschek For backporting stuff.

@karlitschek

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

yes. Backport please. Great work.

@ghost

This comment has been minimized.

Copy link

commented Sep 19, 2014

🚀 Test Passed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org/job/pull-request-analyser/7470/

@PVince81

This comment has been minimized.

Copy link
Member

commented Sep 19, 2014

Works 👍

PVince81 added a commit that referenced this pull request Sep 19, 2014
…or-versions

Prevent updates between multiple major versions
@PVince81 PVince81 merged commit f0186d9 into master Sep 19, 2014
1 check passed
1 check passed
default Merged build finished.
Details
@PVince81 PVince81 deleted the check-for-updates-between-major-versions branch Sep 19, 2014
@PVince81

This comment has been minimized.

Copy link
Member

commented Sep 19, 2014

@LukasReschke can you take care of the backports ? Thanks.

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2014

Stable7: 7f45226

All other branches are not required as stated above.

@PVince81

This comment has been minimized.

Copy link
Member

commented Sep 25, 2014

I was just able to upgrade from stable6 to master because master has 7.8.0.1 as version. It probably doesn't matter as the pre-alpha isn't considered a stable upgrade.

@LukasReschke

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

Yes. This just checks the first number.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.