Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache results of available languages #12464

Merged
merged 1 commit into from Nov 27, 2014

Conversation

Projects
None yet
6 participants
@LukasReschke
Copy link
Member

commented Nov 26, 2014

This function is about 8 times calles for every single page call, when caching this variable I was able to gain a small performance improvement from 20,512 µs to 708 µs. (profiled with xhprof)

Surely, this is no gigantic gain but if we would do that for every function out there...

Before:
screen shot 2014-11-27 at 00 07 35

After:
screen shot 2014-11-27 at 00 09 21

Cache results of available languages
This function is about 8 times calles for every single page call, when caching this variable I was able to gain a small performance improvement from 20,512 µs to 630 µs profiled with xhprof

Surely, this is no gigantic gain but if we would do that for every function out there...
@scrutinizer-notifier

This comment has been minimized.

Copy link

commented Nov 26, 2014

The inspection completed: No new issues

@owncloud-bot

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3354/
🚀 Test PASSed. 🚀

@MorrisJobke

This comment has been minimized.

Copy link
Member

commented Nov 27, 2014

Surely, this is no gigantic gain but if we would do that for every function out there...

That's what DI exactly does ;)

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Nov 27, 2014

👍

1 similar comment
@PVince81

This comment has been minimized.

Copy link
Member

commented Nov 27, 2014

👍

PVince81 added a commit that referenced this pull request Nov 27, 2014

@PVince81 PVince81 merged commit a748222 into master Nov 27, 2014

1 check passed

default Merged build finished.
Details

@PVince81 PVince81 deleted the cache-available-languages branch Nov 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.