Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/6101 Autoload preview providers #12483

Merged
merged 4 commits into from Nov 28, 2014

Conversation

Projects
None yet
5 participants
@nickvergessen
Copy link
Contributor

nickvergessen commented Nov 28, 2014

@bantu @LukasReschke @georgehrke @MorrisJobke

This PR:

  • moves the registration of the providers to the initProviders() method, so the class files don't execute code anymore
  • fixes the doc blocks on the methods
  • marks providers which are not final as abstract
  • moves providers to their own class files

Anti-Whitespace diff: https://github.com/owncloud/core/pull/12483/files?w=1
#6101

@nickvergessen nickvergessen added this to the 8.0-current milestone Nov 28, 2014

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Nov 28, 2014

The inspection completed: 10 new issues, 1 updated code elements

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 28, 2014

Tested with following file formats

.ai
.bmp
.docx
.eps
.jpg
.mp4
.odt
.pdf
.psd
.svg
.TIF

After enabling the previews, all are generated fine - could not see any suspicious errors in the log👍

@owncloud-bot

This comment has been minimized.

Copy link
Contributor

owncloud-bot commented Nov 28, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3435/
🚀 Test PASSed. 🚀

@LukasReschke

This comment has been minimized.

Copy link
Member

LukasReschke commented Nov 28, 2014

👍

LukasReschke added a commit that referenced this pull request Nov 28, 2014

@LukasReschke LukasReschke merged commit b3afc98 into master Nov 28, 2014

1 check passed

default Merged build finished.
Details

@LukasReschke LukasReschke deleted the issue/6101-preview-providers branch Nov 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.