Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] add verbosity check and show repair info & steps #17088

Merged
merged 2 commits into from Jul 1, 2015

Conversation

@MorrisJobke
Copy link
Contributor

MorrisJobke commented Jun 23, 2015

cc @LukasReschke @DeepDiver1975 @nickvergessen @PVince81

I would like to have this at least in 8.1.x. This help to find issues during a upgrade more easiely. I'm also open to backport this to older branches, but that decision is up to @karlitschek

  • add documentation once this is merged

Now you can add the -v option and it will be more verbose (shows repair info and repair steps):

$ ./occ upgrade -v
ownCloud or one of the apps require upgrade - only a limited number of commands are available
Turned on maintenance mode
Repair step: Repair MySQL database engine
Repair info: Not a mysql database -> nothing to do
Repair step: Repair MySQL collation
Repair info: Not a mysql database -> nothing to no
Repair step: Repair SQLite autoincrement
Repair step: Repair duplicate entries in oc_lucene_status
Repair info: lucene_status table does not exist -> nothing to do
Repair step: Repair config
Checked database schema update
Checked database schema update for apps
Updated database
Repair step: Repair mime types
Repair step: Repair legacy storages
Repair step: Repair config
Repair step: Clear asset cache after upgrade
Repair info: Asset pipeline disabled -> nothing to do
Repair step: Generate ETags for file where no ETag is present.
Repair info: ETags have been fixed for 0 files/folders.
Repair step: Clean tags and favorites
Repair info: 0 tags for delete files have been removed.
Repair info: 0 tag entries for deleted tags have been removed.
Repair info: 0 tags with no entries have been removed.
Repair step: Drop old database tables
Repair step: Drop old background jobs
Update successful
Turned off maintenance mode

Also the old way works:

$ ./occ upgrade       
ownCloud or one of the apps require upgrade - only a limited number of commands are available
Turned on maintenance mode
Checked database schema update
Checked database schema update for apps
Updated database
Update successful
Turned off maintenance mode
@MorrisJobke MorrisJobke added this to the 8.1-current milestone Jun 23, 2015
@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jun 23, 2015

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 23, 2015

Sounds useful to me 👍

@MorrisJobke MorrisJobke modified the milestones: 8.2-next, 8.1-current Jun 23, 2015
@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jun 23, 2015

@DeepDiver1975 @cmonteroluque Decide on this if this should go into 8.1 or 8.2. In either case I would at least propose a backport to stable8 and stable8.1

@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jun 23, 2015

I added a repair info for the collation change to this PR because it is related to that change.

@Xenopathic
Copy link
Member

Xenopathic commented Jun 23, 2015

Cool! 👍

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 23, 2015

@MorrisJobke the branch is dead:

13:14:36 ERROR: Error fetching remote repo 'origin'
13:14:36 hudson.plugins.git.GitException: Failed to fetch from https://github.com/owncloud/core.git
13:14:36    at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
13:14:36    at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
13:14:36    at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
13:14:36    at hudson.scm.SCM.checkout(SCM.java:485)
13:14:36    at hudson.model.AbstractProject.checkout(AbstractProject.java:1282)
13:14:36    at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:610)
13:14:36    at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
13:14:36    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:532)
13:14:36    at hudson.model.Run.execute(Run.java:1744)
13:14:36    at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
13:14:36    at hudson.model.ResourceController.execute(ResourceController.java:98)
13:14:36    at hudson.model.Executor.run(Executor.java:374)
@MorrisJobke MorrisJobke force-pushed the add-verbosity-to-upgrade branch to 17ff77c Jun 24, 2015
@scrutinizer-notifier
Copy link

scrutinizer-notifier commented Jun 24, 2015

A new inspection was created.

@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jun 24, 2015

Jenkins succeeded: #17126 (comment)

@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jul 1, 2015

stable8.1 is created -> merge

MorrisJobke added a commit that referenced this pull request Jul 1, 2015
[upgrade] add verbosity check and show repair info & steps
@MorrisJobke MorrisJobke merged commit b5c9196 into master Jul 1, 2015
1 check failed
1 check failed
default Build finished.
Details
@MorrisJobke MorrisJobke deleted the add-verbosity-to-upgrade branch Jul 1, 2015
@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Jul 7, 2015

Backport see #17429

@MorrisJobke MorrisJobke mentioned this pull request Jul 9, 2015
3 of 3 tasks complete
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.