[upgrade] print update message before running the update code #17090

Merged
merged 1 commit into from Jun 23, 2015

Conversation

Projects
None yet
6 participants
@MorrisJobke
Member

MorrisJobke commented Jun 23, 2015

  • otherwise you don't know which app update failed

cc @nickvergessen @LukasReschke @DeepDiver1975 @PVince81

@DeepDiver1975 @cmonteroluque Decide on 8.1 or 8.2. I would then propose a backport to 8.1 and maybe more. cc @karlitschek

@MorrisJobke MorrisJobke added this to the 8.2-next milestone Jun 23, 2015

@owncloud-bot

This comment has been minimized.

Show comment
Hide comment
@owncloud-bot

owncloud-bot Jun 23, 2015

Contributor

🚀 Test PASSed.🚀
chuck

Contributor

owncloud-bot commented Jun 23, 2015

🚀 Test PASSed.🚀
chuck

@nickvergessen

View changes

core/command/upgrade.php
@@ -158,6 +158,9 @@ function () use($output, $updateStepEnabled, $self) {
$updater->listen('\OC\Updater', 'appUpgradeCheck', function () use ($output) {
$output->writeln('<info>Checked database schema update for apps</info>');
});
+ $updater->listen('\OC\Updater', 'appUpgradeStarted', function ($app, $version) use ($output) {
+ $output->writeln("<info>Update <$app> ...</info>");

This comment has been minimized.

@nickvergessen

nickvergessen Jun 23, 2015

Contributor

I'd say Updating <$app> ...

@nickvergessen

nickvergessen Jun 23, 2015

Contributor

I'd say Updating <$app> ...

This comment has been minimized.

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Jun 23, 2015

Member

I like this A LOT. Please put it in master and 8.1
We need to be way more verbose during upgrade.

Member

karlitschek commented Jun 23, 2015

I like this A LOT. Please put it in master and 8.1
We need to be way more verbose during upgrade.

@karlitschek

This comment has been minimized.

Show comment
Hide comment
Member

karlitschek commented Jun 23, 2015

👍

[upgrade] print update message before running the update code
* otherwise you don't know during which app update something failed
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Jun 23, 2015

Member

👍

Member

butonic commented Jun 23, 2015

👍

butonic added a commit that referenced this pull request Jun 23, 2015

Merge pull request #17090 from owncloud/upgrade-app-info
[upgrade] print update message before running the update code

@butonic butonic merged commit 4b53243 into master Jun 23, 2015

@butonic butonic deleted the upgrade-app-info branch Jun 23, 2015

@MorrisJobke MorrisJobke modified the milestones: 8.1-current, 8.2-next Jun 23, 2015

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 23, 2015

The inspection completed: 2 new issues

The inspection completed: 2 new issues

@MorrisJobke MorrisJobke referenced this pull request in owncloud/documentation Jul 9, 2015

Closed

occ upgrade is now more verbose #1304

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment