[upgrade] print update message before running the update code #17090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -158,6 +158,9 @@ function () use($output, $updateStepEnabled, $self) { | |||
| $updater->listen('\OC\Updater', 'appUpgradeCheck', function () use ($output) { | |||
| $output->writeln('<info>Checked database schema update for apps</info>'); | |||
| }); | |||
| $updater->listen('\OC\Updater', 'appUpgradeStarted', function ($app, $version) use ($output) { | |||
| $output->writeln("<info>Update <$app> ...</info>"); | |||
There was a problem hiding this comment.
I'd say Updating <$app> ...
|
I like this A LOT. Please put it in master and 8.1 |
|
|
* otherwise you don't know during which app update something failed
MorrisJobke
force-pushed
the
upgrade-app-info
branch
from
7d3d012
to
1ba9fd3
Compare
|
|
butonic
added a commit
that referenced
this pull request
Jun 23, 2015
[upgrade] print update message before running the update code
|
The inspection completed: 2 new issues |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
cc @nickvergessen @LukasReschke @DeepDiver1975 @PVince81
@DeepDiver1975 @cmonteroluque Decide on 8.1 or 8.2. I would then propose a backport to 8.1 and maybe more. cc @karlitschek