Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] print update message before running the update code #17090

Merged
merged 1 commit into from Jun 23, 2015

Conversation

@MorrisJobke
Copy link
Contributor

MorrisJobke commented Jun 23, 2015

  • otherwise you don't know which app update failed

cc @nickvergessen @LukasReschke @DeepDiver1975 @PVince81

@DeepDiver1975 @cmonteroluque Decide on 8.1 or 8.2. I would then propose a backport to 8.1 and maybe more. cc @karlitschek

@MorrisJobke MorrisJobke added this to the 8.2-next milestone Jun 23, 2015
@ghost
Copy link

ghost commented Jun 23, 2015

🚀 Test PASSed.🚀
chuck

@nickvergessen
nickvergessen reviewed Jun 23, 2015
View changes
core/command/upgrade.php Outdated
@@ -158,6 +158,9 @@ function () use($output, $updateStepEnabled, $self) {
$updater->listen('\OC\Updater', 'appUpgradeCheck', function () use ($output) {
$output->writeln('<info>Checked database schema update for apps</info>');
});
$updater->listen('\OC\Updater', 'appUpgradeStarted', function ($app, $version) use ($output) {
$output->writeln("<info>Update <$app> ...</info>");

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Jun 23, 2015

Contributor

I'd say Updating <$app> ...

This comment has been minimized.

Copy link
@MorrisJobke

MorrisJobke Jun 23, 2015

Author Contributor

Done

@karlitschek
Copy link
Contributor

karlitschek commented Jun 23, 2015

I like this A LOT. Please put it in master and 8.1
We need to be way more verbose during upgrade.

@karlitschek
Copy link
Contributor

karlitschek commented Jun 23, 2015

👍

* otherwise you don't know during which app update something failed
@MorrisJobke MorrisJobke force-pushed the upgrade-app-info branch to 1ba9fd3 Jun 23, 2015
@butonic
Copy link
Member

butonic commented Jun 23, 2015

👍

butonic added a commit that referenced this pull request Jun 23, 2015
[upgrade] print update message before running the update code
@butonic butonic merged commit 4b53243 into master Jun 23, 2015
@butonic butonic deleted the upgrade-app-info branch Jun 23, 2015
@MorrisJobke MorrisJobke modified the milestones: 8.1-current, 8.2-next Jun 23, 2015
@scrutinizer-notifier
Copy link

scrutinizer-notifier commented Jun 23, 2015

The inspection completed: 2 new issues

@MorrisJobke MorrisJobke mentioned this pull request Jul 9, 2015
3 of 3 tasks complete
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.