[stable8.1] Keep scroll position in users page when sorting #21694

Merged
merged 1 commit into from Jan 15, 2016

Projects

None yet

4 participants

@PVince81
Collaborator

Backport of #21509

Please review @MorrisJobke @blizzz

@PVince81 PVince81 Keep scroll position in users page when sorting
When sorting, some browsers like Chrome will lose the scroll position,
possibly because the sorting code is touching the DOM elements.

This fix saves the scroll position before sorting and sets it back
afterwards.
c553974
@PVince81 PVince81 added this to the 8.1.6-current-maintenance milestone Jan 13, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @blizzz, @ringmaster and @MorrisJobke to be potential reviewers

@MorrisJobke
Member

Reproduced on stable8.1 and tested with this -> works 👍

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 40b76df into stable8.1 Jan 15, 2016

14 of 19 checks passed

core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #50208 failed in 4 min 33 sec
Details
ocs-api-integration-tests-ci Build #6111 failed in 4.7 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #33122 failed in 2 min 37 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #10318 failed in 9 min 45 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #10318 failed in 11 min
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #56669 succeeded in 8 min 32 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #25157 succeeded in 15 min
Details
core-ci-linux/database=oci,label=SLAVE Build #25157 succeeded in 20 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #25157 succeeded in 12 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #25157 succeeded in 8 min 4 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #5850 succeeded in 4 min 12 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #5850 succeeded in 3 min 53 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #5850 succeeded in 6 min 45 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #6040 succeeded in 2 min 1 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #10318 succeeded in 2 min 47 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #10318 succeeded in 8 min 16 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #10318 succeeded in 7 min 5 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #10318 succeeded in 5 min 53 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #10318 succeeded in 17 min
Details
@DeepDiver1975 DeepDiver1975 deleted the stable8.1-users-scrolltop branch Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment