Remove browser autocomplete in new file menu #22784

Merged
merged 1 commit into from Mar 3, 2016

Projects

None yet

8 participants

@PVince81
Collaborator
PVince81 commented Mar 2, 2016

That got annoying after a while...

Please review @jancborchardt @LukasReschke @icewind1991 @rullzer @MorrisJobke

@PVince81 PVince81 Remove browser autocomplete in new file menu
5676216
@PVince81 PVince81 added this to the 9.0.1-next-maintenance milestone Mar 2, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @otetard and @jancborchardt to be potential reviewers

@rullzer
Contributor
rullzer commented Mar 2, 2016

👍

@LukasReschke
Member

Works 👍

@MorrisJobke
Member

@karlitschek Is a backport to stable9 fine?

@karlitschek
Member

backport is fine 👍

@DeepDiver1975 DeepDiver1975 merged commit c590372 into master Mar 3, 2016

22 checks passed

Scrutinizer No new issues
Details
cla-bot-core Build #1875 succeeded in 10 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #58828 succeeded in 34 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #52777 succeeded in 14 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #27524 succeeded in 27 min
Details
core-ci-linux/database=oci,label=SLAVE Build #27523 succeeded in 1 hr 7 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #27522 succeeded in 22 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #27522 succeeded in 12 min
Details
ocs-api-integration-tests-ci Build #7997 succeeded in 7 min 56 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #7796 succeeded in 1 min 19 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #7796 succeeded in 3 min 28 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #7796 succeeded in 5 min 0 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #8139 succeeded in 2 min 37 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #35563 succeeded in 3 min 11 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 6 min 18 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 21 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 35 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 13 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 33 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #12128 succeeded in 16 min
Details
@DeepDiver1975 DeepDiver1975 deleted the files-newmenu-removebrowsercomplete branch Mar 3, 2016
@jancborchardt
Member

Yeah, good call. Also on backport.

@PVince81
Collaborator
PVince81 commented Mar 3, 2016

I think 8.2 has it too, because that's where the problem appeared.
So, backport to stable8.2 and stable9

@MorrisJobke
Member

So, backport to stable8.2 and stable9

Could you create the backport PRs?

@PVince81
Collaborator
PVince81 commented Mar 7, 2016

Will do

@PVince81
Collaborator
PVince81 commented Mar 7, 2016

stable9: #22926
stable8.2: #22927

@MorrisJobke MorrisJobke commented on the diff Mar 8, 2016
apps/files/js/newfilemenu.js
@@ -27,7 +27,7 @@
var TEMPLATE_FILENAME_FORM =
'<form class="filenameform">' +
'<label class="hidden-visually" for="{{cid}}-input-{{fileType}}">{{fileName}}</label>' +
- '<input id="{{cid}}-input-{{fileType}}" type="text" value="{{fileName}}">' +
+ '<input id="{{cid}}-input-{{fileType}}" type="text" value="{{fileName}}" autocomplete="off" autocapitalize="off" autocorrect="off">' +
@MorrisJobke
MorrisJobke Mar 8, 2016 Member

Why the autocorrect statement? Often I want to use the autocorrection also for filenames. Only the autocomplete and autocapitalize should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment