Fix syncing of all birthday calendars in one go #23035

Merged
merged 1 commit into from Mar 9, 2016

Projects

None yet

6 participants

@nickvergessen
Contributor
./occ dav:sync-birthday-calendar

  [InvalidArgumentException]  
  User <> in unknown.         

dav:sync-birthday-calendar [<user>]

The problem is unlike hasOption, hasArgument is always true (even when the argument is not set)
A bit awkward, but checking for getArgument !== null fixes the issue. Null is the default value.

@LukasReschke @DeepDiver1975 @MorrisJobke

@karlitschek backport to 9.0.1 would be cool

@nickvergessen nickvergessen Fix syncing of all birthday calendars in one go
8c4af74
@nickvergessen nickvergessen added this to the 9.1-current milestone Mar 9, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @DeepDiver1975 to be a potential reviewer

@DeepDiver1975
Member

THX @nickvergessen

👍

@DeepDiver1975
Member

@karlitschek backport to 9.0.1 would be cool

I support this - @nickvergessen please open backport pr - thx

@nickvergessen
Contributor

Backport is in #23036

@karlitschek
Member

please backport 👍

@MorrisJobke
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 822541b into master Mar 9, 2016

6 of 7 checks passed

Scrutinizer Created
Details
cla-bot-core Build #2086 succeeded in 13 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #59155 succeeded in 1 min 36 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #8426 succeeded in 2 min 35 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #453 succeeded in 5 min 55 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #35913 succeeded in 4 min 57 sec
Details
@DeepDiver1975 DeepDiver1975 deleted the fix-syncing-of-all-birthday-calendars branch Mar 9, 2016
@enoch85
Member
enoch85 commented Mar 10, 2016

Just want to confirm that syncing all the users fixed the issue with DAVdroid missing birthdays. Thanks! cc @jancborchardt @georgehrke

@MorrisJobke
Member

Backported within #23113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment