remove deprecated ldap_sort #23086

Merged
merged 1 commit into from Mar 10, 2016

Projects

None yet

6 participants

@blizzz
Contributor
blizzz commented Mar 10, 2016

ldap_sort is deprecated since PHP 7.

Anyway it did not really do a server side sort, only in those already fetched results. Even if it would be on the server side, with paged results this would not work, as it is not supported by spec.

Since it does not provide any benefit at all, we can simply drop it.

Currently it throws E_DEPRECATED erros on PHP 7, thus it's a candidate for a backporting to 9.0.

LDAP Integration tests ran successful.

cc @danimo

please test and review @owncloud/ldap

@blizzz blizzz remove deprecated ldap_sort
fe2a506
@blizzz blizzz added this to the 9.1-current milestone Mar 10, 2016
@blizzz
Contributor
blizzz commented Mar 10, 2016

@karlitschek backport to stable9? it avoids E_DEPRECATED notices on PHP 7. We don't lose functionality.

@danimo
Member
danimo commented Mar 10, 2016

Seconded, this makes the logfile look rather busy.

@karlitschek
Member

makes sense. please backport

@danimo
Member
danimo commented Mar 10, 2016

๐Ÿ‘

@blizzz
Contributor
blizzz commented Mar 10, 2016

backport to stable9 goes here: #23112

@blizzz
Contributor
blizzz commented Mar 10, 2016

failing test unrelated (Oracle connection could not be established)

@DeepDiver1975 DeepDiver1975 merged commit 866de3c into master Mar 10, 2016

22 of 23 checks passed

core-ci-linux/database=oci,label=SLAVE Build #27859 failed in 16 min
Details
Scrutinizer 49 new issues, 24 updated code elements
Details
cla-bot-core Build #2118 succeeded in 12 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #59212 succeeded in 17 min
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #53173 succeeded in 36 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #27859 succeeded in 26 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #27859 succeeded in 23 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #27859 succeeded in 15 min
Details
ocs-api-integration-tests-ci Build #8265 succeeded in 15 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #8097 succeeded in 3 min 33 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #8097 succeeded in 6 min 57 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #8097 succeeded in 12 min
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #8474 succeeded in 2 min 22 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #517 succeeded in 10 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #35973 succeeded in 5 min 31 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 4 min 45 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 35 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 33 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #12478 succeeded in 14 min
Details
@DeepDiver1975 DeepDiver1975 deleted the ldap-sort-deprecated branch Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment