[stable8.1] Fix broken scanner call in ajax/scan.php #23149

Merged
merged 1 commit into from Mar 14, 2016

Projects

None yet

6 participants

@MorrisJobke
Member

This fixes:

{"reqId":"...","remoteAddr":"10.128.15.50","app":"PHP","message":"Argument 3 passed to OC\\Files\\Utils\\Scanner::__construct() must implement interface OCP\\ILogger, none given, called in apps\/files\/ajax\/scan.php on line 49 and defined at lib\/private\/files\/utils\/scanner.php#71","level":3,"time":"2016-03-10T18:19:19+09:00"} 
{"reqId":"...","remoteAddr":"...","app":"PHP","message":"Undefined variable: logger at lib\/private\/files\/utils\/scanner.php#72","level":3,"time":"2016-03-10T18:19:19+09:00"} 

This somehow slipped through during the backport of #20789 in #21314

cc @PVince81 @icewind1991

cc @karlitschek for this stable8.1 only fix

@MorrisJobke MorrisJobke Fix broken scanner call in ajax/scan.php
62b95c3
@mention-bot

By analyzing the blame information on this pull request, we identified @icewind1991, @LukasReschke and @bartv2 to be potential reviewers

@MorrisJobke MorrisJobke added this to the 8.1.7-current-maintenance milestone Mar 11, 2016
@MorrisJobke
Member

00005014

@icewind1991
Member

Looks good 👍

@karlitschek
Member

please backport

@PVince81
Collaborator

👍

@PVince81 PVince81 merged commit 9978ee3 into stable8.1 Mar 14, 2016

15 of 22 checks passed

Scrutinizer Timed out
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #53243 failed in 37 sec
Details
ocs-api-integration-tests-ci Build #8327 failed in 13 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #622 failed in 2 min 43 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #36078 failed in 41 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #12540 failed in 10 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #12540 failed in 8 min 41 sec
Details
cla-bot-core Build #2185 succeeded in 4 min 36 sec
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #59298 succeeded in 1 min 9 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #27917 succeeded in 16 min
Details
core-ci-linux/database=oci,label=SLAVE Build #27917 succeeded in 51 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #27917 succeeded in 15 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #27917 succeeded in 8 min 37 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #8151 succeeded in 1 min 8 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #8151 succeeded in 29 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #8151 succeeded in 5 min 48 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #8559 succeeded in 3 min 5 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #12540 succeeded in 3 min 24 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #12540 succeeded in 11 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #12540 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #12540 succeeded in 6 min 56 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #12540 succeeded in 16 min
Details
@PVince81 PVince81 deleted the stable8.1-fix-broken-interface branch Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment