[stable9] Prevent certain DBs throwing exceptions on same-value updates #23309

Merged
merged 1 commit into from Mar 17, 2016

Projects

None yet

5 participants

@blizzz
Contributor
blizzz commented Mar 16, 2016

A PreconditionNotMetException must only be thrown if explicit
preconditions are specified for setValues(), not if the value is merely
the same as was already in the DB.

Straight backport of @Xenopathic`s #23164 to stable9

Please test and review @DeepDiver1975 @mossholderm

@Xenopathic @blizzz Xenopathic Prevent certain DBs throwing exceptions on same-value updates
A PreconditionNotMetException must only be thrown if explicit
preconditions are specified for setValues(), not if the value is merely
the same as was already in the DB.
aa91d50
@blizzz blizzz added this to the 9.0.1-current-maintenance milestone Mar 16, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @Xenopathic, @icewind1991 and @bartv2 to be potential reviewers

@blizzz blizzz changed the title from Prevent certain DBs throwing exceptions on same-value updates to [stable9] Prevent certain DBs throwing exceptions on same-value updates Mar 16, 2016
@blizzz
Contributor
blizzz commented Mar 16, 2016

I straight cherry-picked @Xenopathic`s code and stuff works as usual for me, 👍

@PVince81
Collaborator

👍

@DeepDiver1975 DeepDiver1975 merged commit 382b18e into stable9 Mar 17, 2016

21 checks passed

cla-bot-core Build #2332 succeeded in 12 sec
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #59496 succeeded in 29 min
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #53456 succeeded in 32 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #28102 succeeded in 24 min
Details
core-ci-linux/database=oci,label=SLAVE Build #28102 succeeded in 53 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #28102 succeeded in 22 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #28102 succeeded in 12 min
Details
ocs-api-integration-tests-ci Build #8487 succeeded in 15 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #8308 succeeded in 11 min
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #8308 succeeded in 13 min
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #8308 succeeded in 13 min
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #8727 succeeded in 2 min 18 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #838 succeeded in 16 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #36293 succeeded in 11 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 6 min 39 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 38 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 36 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 20 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 34 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #12701 succeeded in 9 min 51 sec
Details
@DeepDiver1975 DeepDiver1975 deleted the backport-23164-stable9 branch Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment