[stable9] Log more information by default #23464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the logger to add the following logging information by default: - Request Method - Request URL - Current user
|
By analyzing the blame information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @Phiber2000 to be potential reviewers |
|
Tested and works 👍 |
MorrisJobke
force-pushed
the
stable9-backport-23443
branch
from
177ad39
to
654f1f8
Compare
|
Rebased to retrigger CI |
|
@LukasReschke Why "2 - Developing"? I checked it with the command line tool, cron and the web UI all work. |
|
This change is suspected to break ci on mysql |
Because of #23488 😉 |
Could you add that fix to this PR? |
When installing ownCloud with autotest and MySQL some log entries may be created which will invoke the logging class. IUserSession has a dependency on the database which will make the installation fail => 💣
LukasReschke
force-pushed
the
stable9-backport-23443
branch
from
654f1f8
to
43516eb
Compare
Done. |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23443