[stable9] Dropbox stream download with RetryWrapper #23522

Merged
merged 2 commits into from Mar 31, 2016

Projects

None yet

8 participants

@PVince81
Collaborator

Note: this backport required #23372 to work, as that was on master already but not backported.

Backport of #23516 to stable9

@icewind1991 @Xenopathic @SergioBertolinSG

PVince81 added some commits Mar 15, 2016
@PVince81 PVince81 Fix dropbox storage to not store the whole file in memory
Since the library can only store the full response in memory on
download, we use an alternate client lib and set the correct headers to
be able to stream the content to a temp file.
443d72e
@PVince81 PVince81 Dropbox stream download with RetryWrapper
195cf41
@PVince81 PVince81 added this to the 9.0.1-current-maintenance milestone Mar 23, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @Xenopathic, @icewind1991 and @realriot to be potential reviewers

@DeepDiver1975 DeepDiver1975 changed the title from [stable9] Dropbox stream download with RetryWrapper to [stable9] Dropbox stream download with RetryWrapper Mar 23, 2016
@PVince81 PVince81 referenced this pull request Mar 23, 2016
Merged

Dropbox stream download with RetryWrapper #23516

3 of 3 tasks complete
@icewind1991
Member

👍

@rperezb
Member
rperezb commented Mar 29, 2016

@davitol can you please check it against 9.0.1 thx

@davitol
Contributor
davitol commented Mar 30, 2016

@davitol can you please check it against 9.0.1 thx

@rperezb It did not WFM against master

#23516 (comment)

@davitol
Contributor
davitol commented Mar 31, 2016

Testing with 2.1.1 Desktop version. The following messages were shown in 'not synced' tab. But, the file was already sync in the DropBox mountpoint. Just waiting for a couple of minutes, the messages disappeared.

NO server logs were found.

wrapdrop

Tested with OSX and Windows Desktop version and with files of 50MB and 100 MB. Same behaviour in all cases.

@davitol
Contributor
davitol commented Mar 31, 2016

The messages of the previous comment are also shown in stable9 without applying the patch so the PR is not related to them

👍

@LukasReschke
Member

👍

@karlitschek karlitschek merged commit 05fd4f2 into stable9 Mar 31, 2016

21 of 22 checks passed

server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #8613 failed in 58 sec
Details
cla-bot-core Build #2594 succeeded in 18 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #59939 succeeded in 2 min 53 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #53899 succeeded in 13 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #28471 succeeded in 15 min
Details
core-ci-linux/database=oci,label=SLAVE Build #28471 succeeded in 33 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #28471 succeeded in 16 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #28471 succeeded in 9 min 59 sec
Details
ocs-api-integration-tests-ci Build #8836 succeeded in 15 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #8613 succeeded in 1 min 19 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #8613 succeeded in 3 min 26 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #9370 succeeded in 2 min 22 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #1290 succeeded in 5 min 5 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #36739 succeeded in 4 min 45 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 6 min 57 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 41 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 39 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 21 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 36 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 13 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #12960 succeeded in 10 min
Details
@karlitschek karlitschek deleted the stable9-dropbox-stream-download branch Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment