Sanitize more data in config report #23728

Merged
merged 1 commit into from Apr 4, 2016

Conversation

Projects
None yet
6 participants
@LukasReschke
Member

LukasReschke commented Apr 1, 2016

This sanitizes the following keys as well:

  • proxyuserpwd
  • shared_secret of log.condition
  • license-key
  • password of redis

cc @MorrisJobke @nickvergessen Mind reviewing?

Sanitize more data in config report
This sanitizes the following keys as well:

- `proxyuserpwd`
- `shared_secret` of `log.condition`
- `license-key`
- `password` of `redis`

@LukasReschke LukasReschke added this to the 9.1-current milestone Apr 1, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 1, 2016

By analyzing the blame information on this pull request, we identified @nickvergessen, @MorrisJobke and @rullzer to be potential reviewers

By analyzing the blame information on this pull request, we identified @nickvergessen, @MorrisJobke and @rullzer to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Apr 1, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Apr 1, 2016

Tested and works 👍

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Apr 1, 2016

Contributor

tested 👍

Contributor

georgehrke commented Apr 1, 2016

tested 👍

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 1, 2016

Contributor

I guess its fine, I'm not entire sure about the license, but they user other stuff to verify that, so should be fine

Contributor

nickvergessen commented Apr 1, 2016

I guess its fine, I'm not entire sure about the license, but they user other stuff to verify that, so should be fine

@nickvergessen nickvergessen merged commit 1d542e4 into master Apr 4, 2016

23 checks passed

Scrutinizer No new issues
Details
cla-bot-core Build #2779 succeeded in 9.6 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #60228 succeeded in 49 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #54224 succeeded in 12 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #28777 succeeded in 12 min
Details
core-ci-linux/database=oci,label=SLAVE Build #28777 succeeded in 24 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #28777 succeeded in 12 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #28777 succeeded in 7 min 24 sec
Details
ocs-api-integration-tests-ci Build #9094 succeeded in 8 min 44 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #8849 succeeded in 1 min 36 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #8849 succeeded in 2 min 36 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #8849 succeeded in 3 min 4 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #9897 succeeded in 2 min 16 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #1614 succeeded in 3 min 45 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #37056 succeeded in 2 min 38 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 5 min 17 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 31 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 7 min 5 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 29 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #13203 succeeded in 16 min
Details

@nickvergessen nickvergessen deleted the sanitize-more-data-for-config-report branch Apr 4, 2016

michaelstingl added a commit that referenced this pull request Jul 15, 2016

[stable9] backport of #23728
Sanitize more data in config report

michaelstingl added a commit that referenced this pull request Jul 15, 2016

[stable8.2] backport of #23728
Sanitize more data in config report

VicDeo added a commit that referenced this pull request Aug 10, 2016

[stable8.2] backport of #23728
Sanitize more data in config report

PVince81 added a commit that referenced this pull request Aug 11, 2016

[stable9] backport of #23728
Sanitize more data in config report

DeepDiver1975 added a commit that referenced this pull request Aug 12, 2016

[stable9] backport of #23728 (#25491)
Sanitize more data in config report

DeepDiver1975 added a commit that referenced this pull request Aug 12, 2016

[stable8.2] backport of #23728 (#25492)
* [stable8.2] backport of #23728

Sanitize more data in config report

* remove 'updater.secret' – only needed in oC9+

The new updater didn't exist in 8.2, only in 9.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment