Added white download icons #23891

Merged
merged 1 commit into from Apr 10, 2016

Projects

None yet

4 participants

@skjnldsv
Contributor

If we got white upload icons, we could really use some white download ones.
I'm in need of some for the contacts app, and I think it should be added in core for future possible uses.

Tell me if you think this is a bad idea :)
@owncloud/designers @Henni

@jancborchardt jancborchardt commented on an outdated diff Apr 10, 2016
core/css/icons.css
@@ -86,6 +86,10 @@
background-image: url('../img/actions/download.svg');
}
@jancborchardt
jancborchardt Apr 10, 2016 Member

Cut this line break, so it belongs to the icon-download. Otherwise nice!

@jancborchardt
Member

Nice! Looks like both are correctly minified/compressed, right?

@skjnldsv
Contributor

Well, i used the download icons black, revert the png and just added the fill parameter to the svg (like the upload-icon-white) Don't know if this could me more compressed :)

@jancborchardt Line break removed.

@jancborchardt
Member

Yup, looks good! ๐Ÿ‘

Just squash the commits into one (the first, with the good commit message). :)

You can also in the future just amend your commits with:

git add your files
git commit --amend (keep the same commit message)
git push -f origin branch-name
@skjnldsv
Contributor

Without git rebase?

@skjnldsv skjnldsv Added white download icons
408bdd6
@jancborchardt
Member

Yeah, rebase is optional but different, just for updating it to current master. Amending and force pushing is for using the same commit in the current branch and overwriting it on the remote to not create two commits.

@skjnldsv
Contributor

Nice, I was always using a rebase HEAD to merge multiple commits. I only used ammend to correct an unpushed commit title.
Thanks!

@irgendwie
Member

LGTM ๐Ÿ‘

@skjnldsv
Contributor

let get this merged?

@skjnldsv skjnldsv added this to the 9.1-current milestone Apr 10, 2016
@skjnldsv
Contributor

@jancborchardt should we merge into 9.0.2 too?

@DeepDiver1975
Member

๐Ÿ‘

@DeepDiver1975 DeepDiver1975 merged commit 4d09e24 into master Apr 10, 2016

22 checks passed

Scrutinizer No new issues
Details
cla-bot-core Build #2936 succeeded in 10 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #60443 succeeded in 7 min 11 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #54497 succeeded in 7 min 52 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #29047 succeeded in 16 min
Details
core-ci-linux/database=oci,label=SLAVE Build #29047 succeeded in 32 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #29047 succeeded in 14 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #29046 succeeded in 10 min
Details
ocs-api-integration-tests-ci Build #9341 succeeded in 7 min 45 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #9064 succeeded in 11 min
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #9064 succeeded in 12 min
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #9064 succeeded in 12 min
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #1871 succeeded in 3 min 16 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #37314 succeeded in 1 min 49 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 6 min 49 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 28 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 40 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 38 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 25 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 30 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #13430 succeeded in 43 min
Details
@DeepDiver1975 DeepDiver1975 deleted the add-download-icon-white branch Apr 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment