map oracle driver options to params #23938

Merged
merged 1 commit into from Jun 10, 2016

Projects

None yet

5 participants

@butonic
Member
butonic commented Apr 12, 2016

Supersedes #16266 by reusing the dbdriveroptions and feeding them to oracle as driver options.

Allows using oracle wallet and connection pooling in oracle.

As the driver options are ignored by the doctrine oracle driver we need to remap them to parameters so that something like pooling and external credentials can be configured.

@mention-bot

By analyzing the blame information on this pull request, we identified @bantu, @icewind1991 and @DeepDiver1975 to be potential reviewers

@butonic butonic added this to the 9.1-current milestone Apr 12, 2016
@DeepDiver1975
Member

As the driver options are ignored by the doctrine oracle driver we need to remap them to parameters so that something like pooling and external credentials can be configured.

Upstream bug?

@butonic butonic referenced this pull request in doctrine/dbal Apr 12, 2016
Open

oracle driver ignores driver options #2356

@PVince81
Collaborator

Upstream bug?

@butonic ?

@PVince81
Collaborator

I'm fine to add this as workaround for now... @DeepDiver1975 what do you think ?
Else close this and submit an upstream PR + update libs and need to think about backportability if applicable.

@PVince81
Collaborator

@DeepDiver1975 @butonic any update ? Close ?

@butonic
Member
butonic commented May 31, 2016 edited

I want this in. Upstream is ... slow to respond to oracle PRs. This PR is at least against code that we control. And it only affects oracle. It fixes a customer issue we otherwise have to patch.

@PVince81
Collaborator

I don't mind, if this works then πŸ‘

@DeepDiver1975 your decision ?

@DeepDiver1975
Member

I want this in. Upstream is ... slow to respond to oracle PRs. This PR is at least against code that we control. And it only affects oracle. It fixes a customer issue we otherwise have to patch.

I'm okay with the workaround - we should still submit this patch upstream

@butonic @DeepDiver1975 butonic map oracle driver options to params
1335cb5
@ChristophWurst
Contributor

I'm okay with the workaround

@DeepDiver1975 is that a πŸ‘? :-)

@DeepDiver1975
Member

I'm okay with the workaround - we should still submit this patch upstream

@butonic we should still try to be a good citizen - mind preparing the pr? THX

@DeepDiver1975
Member

@DeepDiver1975 is that a πŸ‘? :-)

yes

@DeepDiver1975 DeepDiver1975 merged commit c668588 into master Jun 10, 2016

13 of 14 checks passed

ocs-api-integration-tests-ci Build #11320 in progress...
Details
Scrutinizer No new issues
Details
cla-bot-core Build #4611 succeeded in 59 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62541 succeeded in 39 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #21275 succeeded in 3 min 4 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #39742 succeeded in 13 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 3 min 39 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 5 min 36 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 7 min 43 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 24 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 10 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15220 succeeded in 27 min
Details
@DeepDiver1975 DeepDiver1975 deleted the maporacleoptions branch Jun 10, 2016
@butonic
Member
butonic commented Nov 30, 2016

reported upstream in doctrine/dbal#2356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment