[stable9] on clone Connection, do not take over the existing LDAP resource #24236

Merged
merged 1 commit into from Apr 25, 2016

Projects

None yet

4 participants

@blizzz
Contributor
blizzz commented Apr 25, 2016

For one, it solves potential conflicts when using the resource. For the
other, one on the login check (the only place where a clone happens
currently) we do not need to rebind after confirming the user's login
was successful.

Backport of #24214

Please test and review @owncloud/ldap @MorrisJobke @MarcoO74 @PVince81 @owncloud/qa

@blizzz blizzz on clone Connection, do not take over the existing LDAP resource
For one, it solves potential conflicts when using the resource. For the
other, one on the login check (the only place where a clone happens
currently) we do not need to rebind after confirming the user's login
was successful.
8ebde1e
@blizzz blizzz added this to the 9.0.2-current-maintenance milestone Apr 25, 2016
@blizzz
Contributor
blizzz commented Apr 25, 2016

Oracle failing because setup hickup

…
Installing ....
06:57:58 ownCloud is not installed - only a limited number of commands are available
06:57:58 Oracle connection could not be established
06:57:58  -> ORA-01017: invalid username/password; logon denied Check environment: ORACLE_HOME=/usr/lib/oracle/xe/app/oracle/product/10.2.0/server ORACLE_SID=XE LD_LIBRARY_PATH=/usr/lib/oracle/xe/app/oracle/product/10.2.0/server/lib: NLS_LANG=AMERICAN_AMERICA.AL32UTF8 tnsnames.ora is readable
…

changes are not DB related.

@PVince81
Collaborator

LDAP still works 👍

@MorrisJobke
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit b425a0e into stable9 Apr 25, 2016

21 of 22 checks passed

core-ci-linux/database=oci,label=SLAVE Build #29830 failed in 14 min
Details
cla-bot-core Build #3477 succeeded in 4 min 28 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #61230 succeeded in 2 min 22 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #55364 succeeded in 31 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #29830 succeeded in 21 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #29830 succeeded in 22 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #29830 succeeded in 13 min
Details
ocs-api-integration-tests-ci Build #10046 succeeded in 13 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #9679 succeeded in 6 min 6 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #9679 succeeded in 6 min 57 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #9679 succeeded in 8 min 16 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #12610 succeeded in 4 min 1 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #2771 succeeded in 11 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #38063 succeeded in 22 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 27 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 53 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 1 hr 2 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 50 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 22 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #14010 succeeded in 25 min
Details
@DeepDiver1975 DeepDiver1975 deleted the backport-24214-stable9 branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment