New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ownCloud work again in php 7.0.6 #24326

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
@rullzer
Contributor

rullzer commented Apr 28, 2016

@rullzer rullzer added this to the 9.1-current milestone Apr 28, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 28, 2016

By analyzing the blame information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @Xenopathic to be potential reviewers

mention-bot commented Apr 28, 2016

By analyzing the blame information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @Xenopathic to be potential reviewers

@@ -271,6 +271,9 @@ public function __get($name) {
* @return bool
*/
public function __isset($name) {
if (in_array($name, $this->allowedKeys, true)) {

This comment has been minimized.

@nickvergessen

nickvergessen Apr 28, 2016

Contributor

use hasMember?

@nickvergessen

nickvergessen Apr 28, 2016

Contributor

use hasMember?

This comment has been minimized.

@rullzer

rullzer Apr 28, 2016

Contributor

how?

@rullzer

rullzer Apr 28, 2016

Contributor

how?

This comment has been minimized.

@thomasvnl

thomasvnl Jul 21, 2016

This worked for me. Pulled a PHP 7 update from Ubuntu's official update repo's and my ownCloud broke down. Thanks to all who came up with a patch!

@thomasvnl

thomasvnl Jul 21, 2016

This worked for me. Pulled a PHP 7 update from Ubuntu's official update repo's and my ownCloud broke down. Thanks to all who came up with a patch!

This comment has been minimized.

@ghost

ghost Jul 21, 2016

@thomasvnl You don't need this patch. Just use the current oC version 9.0.4 which already includes this.

@ghost

ghost Jul 21, 2016

@thomasvnl You don't need this patch. Just use the current oC version 9.0.4 which already includes this.

This comment has been minimized.

@thomasvnl

thomasvnl Jul 21, 2016

@RealRancor I understand, but yesterday I didn't have time to update my ownCloud from 9.0.0 to 9.0.4. I also noticed the fix isn't mentioned in the changelog, or am I mistaken? I've searched through the changelog first before taking this route.

Thanks for notifying me about the fix being included in 9.0.4.

@thomasvnl

thomasvnl Jul 21, 2016

@RealRancor I understand, but yesterday I didn't have time to update my ownCloud from 9.0.0 to 9.0.4. I also noticed the fix isn't mentioned in the changelog, or am I mistaken? I've searched through the changelog first before taking this route.

Thanks for notifying me about the fix being included in 9.0.4.

This comment has been minimized.

@PVince81

PVince81 Jul 21, 2016

Member

From what I see the fix was already in 9.0.2 #24343

@PVince81

PVince81 Jul 21, 2016

Member

From what I see the fix was already in 9.0.2 #24343

This comment has been minimized.

@ghost

ghost Jul 21, 2016

Yes, and also listed in the (quite large) ChangeLog of 9.0.2:

[Stable 9] Make ownCloud work again in php 7.0.6 - #24343

https://owncloud.org/changelog/

@ghost

ghost Jul 21, 2016

Yes, and also listed in the (quite large) ChangeLog of 9.0.2:

[Stable 9] Make ownCloud work again in php 7.0.6 - #24343

https://owncloud.org/changelog/

This comment has been minimized.

@thomasvnl

thomasvnl Jul 21, 2016

@PVince81 @RealRancor totally missed it! Thanks guys.

@thomasvnl

thomasvnl Jul 21, 2016

@PVince81 @RealRancor totally missed it! Thanks guys.

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Apr 28, 2016

Contributor

Is Jenkins using PHP 7.0.6?

Contributor

oparoz commented Apr 28, 2016

Is Jenkins using PHP 7.0.6?

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz
Contributor

oparoz commented Apr 28, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 28, 2016

Is Jenkins using PHP 7.0.6?

PHP 7.0.6 is not even officially announced:
https://secure.php.net/ChangeLog-7.php
https://secure.php.net/archive/2016.php

ghost commented Apr 28, 2016

Is Jenkins using PHP 7.0.6?

PHP 7.0.6 is not even officially announced:
https://secure.php.net/ChangeLog-7.php
https://secure.php.net/archive/2016.php

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Apr 28, 2016

Contributor

@RealRancor - Of course, but what I'm saying is that we can't be almost absolutely certain that this is the only required change unless the branch uses PHP 7.0.6 for tests.
A newer PHP can be compiled on the CI boxes or we can wait for Travis to catch up, which will take months as they're still using 7.0.4.

Contributor

oparoz commented Apr 28, 2016

@RealRancor - Of course, but what I'm saying is that we can't be almost absolutely certain that this is the only required change unless the branch uses PHP 7.0.6 for tests.
A newer PHP can be compiled on the CI boxes or we can wait for Travis to catch up, which will take months as they're still using 7.0.4.

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Apr 28, 2016

Contributor

I ran the unit test locally with php 7.0.6 (which is tagged alrady) and now they pass.

Contributor

rullzer commented Apr 28, 2016

I ran the unit test locally with php 7.0.6 (which is tagged alrady) and now they pass.

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Apr 28, 2016

Contributor

And at least we know it is not breaking older isntances.

Contributor

rullzer commented Apr 28, 2016

And at least we know it is not breaking older isntances.

@maki-chan

This comment has been minimized.

Show comment
Hide comment
@maki-chan

maki-chan Apr 28, 2016

As an Arch Linux user, I updated to PHP 7.0.6, too, as it was available on the package mirrors during the update I made today. This patch does indeed work and I can use ownCloud on my server again 👍

maki-chan commented Apr 28, 2016

As an Arch Linux user, I updated to PHP 7.0.6, too, as it was available on the package mirrors during the update I made today. This patch does indeed work and I can use ownCloud on my server again 👍

@HLFH

This comment has been minimized.

Show comment
Hide comment
@HLFH

HLFH Apr 28, 2016

I'm also an Arch Linux user and I updated to PHP 7.0.6. This PR fixes the issue. 👍

HLFH commented Apr 28, 2016

I'm also an Arch Linux user and I updated to PHP 7.0.6. This PR fixes the issue. 👍

@rullzer rullzer merged commit 238dbe9 into master Apr 28, 2016

23 checks passed

Scrutinizer No new issues
Details
cla-bot-core Build #3641 succeeded in 11 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #61443 succeeded in 5 min 37 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #55625 succeeded in 9 min 14 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #30083 succeeded in 11 min
Details
core-ci-linux/database=oci,label=SLAVE Build #30083 succeeded in 13 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #30083 succeeded in 10 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #30083 succeeded in 5 min 43 sec
Details
ocs-api-integration-tests-ci Build #10255 succeeded in 9 min 49 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #9864 succeeded in 1 min 21 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #9864 succeeded in 2 min 31 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #9864 succeeded in 2 min 46 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #13312 succeeded in 2 min 23 sec
Details
server-master-linux-php5.4-ci/database=sqlite,label=SLAVE Build #3029 succeeded in 4 min 34 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #38310 succeeded in 2 min 19 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 3 min 34 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 9 min 30 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 24 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 5 min 37 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #14181 succeeded in 7 min 50 sec
Details

@rullzer rullzer deleted the fix_for_php_7_0_6 branch Apr 28, 2016

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Apr 28, 2016

Contributor

@karlitschek we should backport this. Else users on stable 8.2 and 9.0 might run into trouble if they run bleeding edge php

Contributor

rullzer commented Apr 28, 2016

@karlitschek we should backport this. Else users on stable 8.2 and 9.0 might run into trouble if they run bleeding edge php

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Apr 29, 2016

Contributor

Stable 9: #24343
Stable8.2: #24344

Contributor

rullzer commented Apr 29, 2016

Stable 9: #24343
Stable8.2: #24344

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Apr 29, 2016

Member

backport makes sense 👍

Member

karlitschek commented Apr 29, 2016

backport makes sense 👍

@jirkaehm

This comment has been minimized.

Show comment
Hide comment
@jirkaehm

jirkaehm May 1, 2016

Just spent about two hours debugging why owncloud stopped working. Find out that my webhost upgraded to PHP 7.0.6. Fix mentioned above did the trick.

jirkaehm commented May 1, 2016

Just spent about two hours debugging why owncloud stopped working. Find out that my webhost upgraded to PHP 7.0.6. Fix mentioned above did the trick.

@produnis

This comment has been minimized.

Show comment
Hide comment
@produnis

produnis May 2, 2016

this patch worked for me, too!
THX A LOT!!!!

produnis commented May 2, 2016

this patch worked for me, too!
THX A LOT!!!!

@nonamedotc

This comment has been minimized.

Show comment
Hide comment
@nonamedotc

nonamedotc May 3, 2016

Thank you for the patch. I was able to fix up my installation as well!

👍

nonamedotc commented May 3, 2016

Thank you for the patch. I was able to fix up my installation as well!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment