Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ownCloud work again in php 7.0.6 #24326

Merged
merged 1 commit into from Apr 28, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Make ownCloud work again in php 7.0.6

  • Loading branch information
rullzer committed Apr 28, 2016
commit eb11ed18512a1122c4d6f808ba990d7ba1abedbd
@@ -271,6 +271,9 @@ public function __get($name) {
* @return bool
*/
public function __isset($name) {
if (in_array($name, $this->allowedKeys, true)) {

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Apr 28, 2016

Contributor

use hasMember?

This comment has been minimized.

Copy link
@rullzer

rullzer Apr 28, 2016

Author Contributor

how?

This comment has been minimized.

Copy link
@thomasvnl

thomasvnl Jul 21, 2016

This worked for me. Pulled a PHP 7 update from Ubuntu's official update repo's and my ownCloud broke down. Thanks to all who came up with a patch!

This comment has been minimized.

Copy link
@ghost

ghost Jul 21, 2016

@thomasvnl You don't need this patch. Just use the current oC version 9.0.4 which already includes this.

This comment has been minimized.

Copy link
@thomasvnl

thomasvnl Jul 21, 2016

@RealRancor I understand, but yesterday I didn't have time to update my ownCloud from 9.0.0 to 9.0.4. I also noticed the fix isn't mentioned in the changelog, or am I mistaken? I've searched through the changelog first before taking this route.

Thanks for notifying me about the fix being included in 9.0.4.

This comment has been minimized.

Copy link
@PVince81

PVince81 Jul 21, 2016

Member

From what I see the fix was already in 9.0.2 #24343

This comment has been minimized.

Copy link
@ghost

ghost Jul 21, 2016

Yes, and also listed in the (quite large) ChangeLog of 9.0.2:

[Stable 9] Make ownCloud work again in php 7.0.6 - #24343

https://owncloud.org/changelog/

This comment has been minimized.

Copy link
@thomasvnl

thomasvnl Jul 21, 2016

@PVince81 @RealRancor totally missed it! Thanks guys.

return true;
}
return isset($this->items['parameters'][$name]);
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.