[8.2] cache isLocal for shared storage #24841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991 Working fine. Thank you. We could only get this issue to occur on our production environment. Considering our 3 node mysql cluster melted with the previous version of this function, testing this version on production servers was a little scary. But there is no noticeable change in mysql query rate or connections from before (isLocal commented out entirely) and after (this version). Great job. |
|
👍 |
|
Overall OC 8.2.5 produces much more queries than 8.1.6: https://cloudstorage.uni-oldenburg.de/index.php/s/KOH0kiKT3X6nETo Is this an expected behavior? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24651
Better performance for isLocal.
@timm2k @scolebrook can you verify that this fixes the problem for you
9.0/9.1 both have separate sollutions
@PVince81 @rullzer