Catch the ForbiddenException to make sure it gets handled #24949

Merged
merged 1 commit into from Jun 2, 2016

Projects

None yet

4 participants

@nickvergessen
Contributor

Steps

  1. Write a Storage Wrapper that throws ForbiddenException (e.g. for firewall reasons)
  2. Set up a sync client
  3. Try to sync

Expected

403 - Forbidden

Actual

500 - Internal Server Error

Fix owncloud/enterprise#1325

I guess we should backport to 9.0 where we started to use a storage wrapper @PVince81

@nickvergessen nickvergessen Catch the ForbiddenException to make sure it gets handled
942e946
@nickvergessen nickvergessen added this to the 9.1-current milestone Jun 1, 2016
@PVince81
Collaborator
PVince81 commented Jun 1, 2016
@icewind1991
Member

👍 looks good

@PVince81 PVince81 merged commit f584d5f into master Jun 2, 2016

19 of 20 checks passed

core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #56948 failed in 59 sec
Details
Scrutinizer No new issues
Details
cla-bot-core Build #4582 succeeded in 24 sec
Details
continuous-integration/php-5.4 Build #4501 succeeded in 4 min 57 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux/database=mysql,label=SLAVE Build #31369 succeeded in 10 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31369 succeeded in 17 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31369 succeeded in 10 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31369 succeeded in 5 min 22 sec
Details
ocs-api-integration-tests-ci Build #11281 succeeded in 10 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #10823 succeeded in 1 min 12 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #10823 succeeded in 2 min 39 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #21111 succeeded in 2 min 35 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 8 min 30 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 15 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 52 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 41 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 19 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15183 succeeded in 57 min
Details
@PVince81 PVince81 deleted the ee-1325-internal-server-error-in-sync-client-on-forbidden-directurl branch Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment