[stable9] DAV now returns file name with Content-Disposition header #25052

Merged
merged 1 commit into from Jun 15, 2016

Projects

None yet

3 participants

@PVince81
Collaborator

That was a tough backport of #25043 to stable9 due to many conflicts.

Please review and test @owncloud/filesystem @DeepDiver1975 @nickvergessen @rullzer @guruz

Sync client download, cadaver download and Chromium download worked properly.

@PVince81 PVince81 added this to the 9.0.3-current-maintenance milestone Jun 10, 2016
@nickvergessen
Contributor

That was a tough backport of #25043 to stable9 due to many conflicts.

still looks good ;)

However, integration tests failed due to network issues:

[Composer\Downloader\TransportException]
The "https://packagist.org/packages.json" file could not be downloaded: failed to open stream: Connection timed out

since you touched them, I guess it would be nice to rebase (just to be sure)

@PVince81 PVince81 DAV now returns file name with Content-Disposition header
81761b8
@PVince81
Collaborator

Rebased

@PVince81
Collaborator

I just ran the webdav feature tests locally and they went fine.

25 scenarios (25 passed)
157 steps (157 passed)

Seems that the OCS int executor still has timeout troubles. CC @DeepDiver1975

Still need two thumbs up to get this merged.

@PVince81
Collaborator

To test:

  1. Upload a file "test.jpg" to ownCloud
  2. curl -D - -X GET http://localhost/owncloud/remote.php/webdav/test.jpg
  3. Check the "Content-Disposition" header

Before: no filename part
After: filename part is there

Then for the Chrome bug, see #23176
Basically upload a "test.xml" file and download it in the Chromium web UI. Chromium would save it as "test.txt" instead of "test.xml".

@nickvergessen
Contributor

works fine by me, but even before.
But nothing broke and the header is good, so 👍

@rullzer
Contributor
rullzer commented Jun 15, 2016

Header is set here 👍

@PVince81 PVince81 merged commit 3da5d06 into stable9 Jun 15, 2016

19 of 21 checks passed

ocs-api-integration-tests-ci Build #11533 failed in 3 min 12 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11049 failed in 11 min
Details
cla-bot-core Build #4763 succeeded in 32 sec
Details
continuous-integration/php-5.4 Build #4828 succeeded in 6 min 44 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62743 succeeded in 1 min 4 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31652 succeeded in 13 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31652 succeeded in 37 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31652 succeeded in 17 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31652 succeeded in 7 min 36 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11049 succeeded in 2 min 42 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11049 succeeded in 5 min 12 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #22165 succeeded in 3 min 55 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #39950 succeeded in 5 min 26 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 2 hr 48 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 3 hr 36 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 3 hr 0 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 3 hr 49 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 3 hr 27 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 2 hr 53 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15393 succeeded in 3 hr 9 min
Details
@PVince81 PVince81 deleted the stable9-webdav-download-mimetype branch Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment