load authentication apps first #25126

Merged
merged 2 commits into from Jun 16, 2016

Projects

None yet

6 participants

@ChristophWurst
Contributor

fixes https://github.com/owncloud/mail/issues/1422

This fixes a problem of the mail app where code in app.php uses the user manager to get a user. The user manager then asks the registered user backends. However, as mail is loaded before user_ldap, the ldap backend has not been loaded yet ๐Ÿ’ฅ

@DeepDiver1975 as discussed

cc @blizzz @MorrisJobke @LukasReschke @Gomez

@ChristophWurst ChristophWurst load authentication apps first
33482b8
@ChristophWurst ChristophWurst added this to the 9.1-current milestone Jun 15, 2016
@mention-bot

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @bartv2 and @PVince81 to be potential reviewers

@DeepDiver1975
Member

๐Ÿ‘

@ChristophWurst please submit prs for all stable branches down to stable8

@blizzz
Contributor
blizzz commented Jun 15, 2016

Good catch! Isn't it also necessary to load session (before) filesystem and logging (both afterwards) types seperately as well?

@nickvergessen
Contributor

๐Ÿ‘

@ChristophWurst
Contributor

Good catch! Isn't it also necessary to load session (before) filesystem and logging (both afterwards) types seperately as well?

@DeepDiver1975 should I change that order too?

@DeepDiver1975
Member

Yes please @blizzz is totally right.

@ChristophWurst
Contributor

@blizzz @DeepDiver1975 now session apps are loaded before authentication before all other apps. That is exactly what base.php does for logged in users. Please re-review

@ChristophWurst ChristophWurst load session apps before all other apps
ab92a8a
@nickvergessen
Contributor

๐Ÿ‘

@MorrisJobke
Member

I tested this with the mail app and LDAP and it works after applying this patch :)

Thanks ๐Ÿ‘

@DeepDiver1975 DeepDiver1975 merged commit d36a1fe into master Jun 16, 2016

13 of 14 checks passed

core-ci-linux/database=pgsql,label=SLAVE Build #31763 failed in 18 min
Details
Scrutinizer 2 new issues
Details
cla-bot-core Build #4839 succeeded in 51 sec
Details
continuous-integration/php-5.4 Build #4969 succeeded in 6 min 29 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62849 succeeded in 29 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31763 succeeded in 17 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31763 succeeded in 27 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31763 succeeded in 8 min 28 sec
Details
ocs-api-integration-tests-ci Build #11616 succeeded in 12 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11139 succeeded in 2 min 26 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11139 succeeded in 6 min 49 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11139 succeeded in 9 min 13 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40083 succeeded in 5 min 5 sec
Details
@DeepDiver1975 DeepDiver1975 deleted the ocs-load-auth-apps-first branch Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment