Do not recurse link share fetching #25160

Merged
merged 1 commit into from Jun 17, 2016

Projects

None yet

5 participants

@DeepDiver1975
Member
  • Might fix an issue on oracle

@butonic as discussed
@PVince81 @dragotin @guruz

@rullzer @DeepDiver1975 rullzer Do not recurse link share fetching
* Might fix an issue on oracle
2d7bbf4
@mention-bot

By analyzing the blame information on this pull request, we identified @rullzer, @LukasReschke and @nickvergessen to be potential reviewers

@PVince81
Collaborator

Code looks good 👍

@butonic
Member
butonic commented Jun 17, 2016

works as expected and fixes oracle 👍

@PVince81
Collaborator

@DeepDiver1975 needs forward port to master ?

@butonic
Member
butonic commented Jun 17, 2016

@PVince81 nope, https://github.com/owncloud/core/blob/master/lib/private/Share20/Manager.php#L926 is what made @DeepDiver1975 question my other array_udiff PR in the first place

@PVince81 PVince81 merged commit a3111e8 into stable9 Jun 17, 2016

19 of 20 checks passed

server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11189 found unstable in 7 min 2 sec
Details
cla-bot-core Build #4883 succeeded in 2 min 17 sec
Details
continuous-integration/php-5.4 Build #5050 succeeded in 9 min 51 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62932 succeeded in 3 min 3 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31843 succeeded in 14 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31843 succeeded in 49 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31843 succeeded in 29 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31843 succeeded in 8 min 5 sec
Details
ocs-api-integration-tests-ci Build #11680 succeeded in 8 min 22 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11189 succeeded in 2 min 12 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11189 succeeded in 8 min 6 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40165 succeeded in 7 min 51 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 7 min 50 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 1 hr 18 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 26 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 1 hr 1 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15508 succeeded in 1 hr 6 min
Details
@PVince81 PVince81 deleted the fix-oracle-endless-loop-stable9 branch Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment