[stable9] Capped cache for user config #25165

Merged
merged 1 commit into from Jun 20, 2016

Projects

None yet

4 participants

@butonic
Member
butonic commented Jun 17, 2016

use a capped memory cache for user config. during migration we check if a user is enabled ... causing the code to accumulate user config for all users.

ref #24403

@butonic butonic Capped cache for user config
0e3682d
@mention-bot

By analyzing the blame information on this pull request, we identified @MorrisJobke, @icewind1991 and @bartv2 to be potential reviewers

@butonic butonic added this to the 9.0.3-current-maintenance milestone Jun 17, 2016
@butonic butonic changed the title from Capped cache for user config to [stable9] Capped cache for user config Jun 17, 2016
@PVince81
Collaborator

Looks good 👍

@butonic is this specific to master where you added the "fetchall" logic ?

@PVince81
Collaborator

Ah, I see: stable9

@butonic
Member
butonic commented Jun 17, 2016

@PVince81 this is related to user specific config options, not the appconfig / fetchall thing you have in mind.

@PVince81
Collaborator

@butonic is this critical to get merged post-RC ?

@butonic
Member
butonic commented Jun 17, 2016

critical is a hard word. I can try to test the RC at the customer beginning next week. If it passes the upgrade we are good. If not we can try with this patch added.

@guruz
Contributor
guruz commented Jun 17, 2016

👍

@PVince81
Collaborator

Let's merge this one too... so we have a nice collection of memory fixes for OC 9.0.3 since out of memory errors can be critical 👍

@PVince81 PVince81 merged commit 826654b into stable9 Jun 20, 2016

20 checks passed

cla-bot-core Build #4887 succeeded in 16 sec
Details
continuous-integration/php-5.4 Build #5057 succeeded in 6 min 30 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62936 succeeded in 49 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31846 succeeded in 15 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31846 succeeded in 39 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31846 succeeded in 19 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31846 succeeded in 9 min 28 sec
Details
ocs-api-integration-tests-ci Build #11683 succeeded in 29 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11193 succeeded in 4 min 35 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11193 succeeded in 5 min 44 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11193 succeeded in 7 min 49 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40171 succeeded in 5 min 39 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 7 min 55 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 1 hr 21 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 16 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 26 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 54 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 12 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15511 succeeded in 1 hr 10 min
Details
@PVince81 PVince81 deleted the stable9-capped-user-cache branch Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment