[stable9] Delay files_sharing's registerMountProviders #25187

Merged
merged 1 commit into from Jun 20, 2016

Projects

None yet

4 participants

@DeepDiver1975
Member

This moves registerMountProviders until after the sharing backends were
registered. In some situations registerMountProviders will trigger
listeners which might require filesystem access which itself would
mount shares, which itself requires the sharing backends to be
initialized.

backport of #25159

@PVince81 @DeepDiver1975 PVince81 Delay files_sharing's registerMountProviders
This moves registerMountProviders until after the sharing backends were
registered. In some situations registerMountProviders will trigger
listeners which might require filesystem access which itself would
mount shares, which itself requires the sharing backends to be
initialized.
2f61c29
@mention-bot

By analyzing the blame information on this pull request, we identified @icewind1991, @PVince81 and @schiessle to be potential reviewers

@PVince81
Collaborator

👍 thanks for finishing my backport

Second review please @icewind1991 @georgehrke @guruz @ChristophWurst

@ChristophWurst
Contributor

👍

@PVince81 PVince81 merged commit 3e3c17a into stable9 Jun 20, 2016

18 of 20 checks passed

server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11233 found unstable in 5 min 41 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15546 in progress...
Details
cla-bot-core Build #4913 succeeded in 1 min 45 sec
Details
continuous-integration/php-5.4 Build #5105 succeeded in 3 min 58 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #62985 succeeded in 34 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #31899 succeeded in 10 min
Details
core-ci-linux/database=oci,label=SLAVE Build #31899 succeeded in 33 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #31899 succeeded in 31 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #31899 succeeded in 7 min 9 sec
Details
ocs-api-integration-tests-ci Build #11726 succeeded in 7 min 14 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11233 succeeded in 1 min 11 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11233 succeeded in 6 min 21 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40220 succeeded in 3 min 0 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 27 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 51 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 1 hr 14 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 22 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15546 succeeded in 1 hr 19 min
Details
@PVince81 PVince81 deleted the share-app-initorder-stable9 branch Jun 20, 2016
@PVince81
Collaborator

Merged post RC because I think the original issue is critical: update failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment