get only vcards which match both the address book id and the vcard uri #25294

Merged
merged 1 commit into from Jun 29, 2016

Projects

None yet

6 participants

@schiessle
Member

getContact() should only return contacts which match both the address book id and the vcard uri

This is just a one-liner, so there shouldn't be any copyright issues. But if you prefer, I hereby grant you permission to use it under the MIT license.

cc @DeepDiver1975 @PVince81

@schiessle schiessle get only vcards which match both the address book id and the vcard uri
cf0a13f
@mention-bot

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @nickvergessen and @georgehrke to be potential reviewers

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Jun 28, 2016
@DeepDiver1975
Member

Thanks @schiessle - I assume this also affects 9.0.x - right?

@schiessle
Member

@DeepDiver1975 didn't checked it but most likely this needs to be backported

@owncloud-bot
Collaborator

@schiessle

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@georgehrke
Contributor

👍 good catch

@DeepDiver1975
Member

unit tests are green as well 👍

@DeepDiver1975 DeepDiver1975 merged commit d2209d3 into owncloud:master Jun 29, 2016

13 of 15 checks passed

cla-bot-core Build #5063 failed in 16 sec
Details
core-ci-linux/database=oci,label=SLAVE Build #32141 in progress...
Details
Scrutinizer No new issues
Details
continuous-integration/php-5.4 Build #5366 succeeded in 9 min 10 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #63245 succeeded in 58 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #32142 succeeded in 16 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #32143 succeeded in 15 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #32141 succeeded in 8 min 45 sec
Details
ocs-api-integration-tests-ci Build #11923 succeeded in 13 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11420 succeeded in 1 min 17 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11420 succeeded in 6 min 37 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11420 succeeded in 8 min 57 sec
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #23119 succeeded in 5 min 40 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40470 succeeded in 3 min 50 sec
Details
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Jun 29, 2016
@schiessle @DeepDiver1975 schiessle + DeepDiver1975 get only vcards which match both the address book id and the vcard uri ( 1f71285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment