[stable9] fix ldap:check-user command / User Cleanup does not work #25338

Merged
merged 1 commit into from Jul 4, 2016

Projects

None yet

6 participants

@felixboehm
Contributor
felixboehm commented Jul 1, 2016 edited

Fixes User Cleanup does not work owncloud/enterprise#1431
Related: #22024 (comment)

@PVince81 @butonic

@felixboehm felixboehm check if renamed user is still valid by reapplying the ldap filter
52fa7b6
@mention-bot

By analyzing the blame information on this pull request, we identified @blizzz, @MorrisJobke and @dschmidt to be potential reviewers

@felixboehm felixboehm added this to the 9.0.4 milestone Jul 1, 2016
@PVince81
Collaborator
PVince81 commented Jul 1, 2016

@owncloud/ldap @DeepDiver1975

@felixboehm please note that in general PRs have to be submitted against master and backported afterwards.

After reviewing this PR will need to submit PRs for stable9.1 and master too.

@PVince81
Collaborator
PVince81 commented Jul 1, 2016

@owncloud/qa can you help testing this ? Also check if previous versions are affected.

@SergioBertolinSG
Member

Works 👍

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit fdb0d4a into stable9 Jul 4, 2016

20 of 21 checks passed

server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11472 found unstable in 8 min 42 sec
Details
cla-bot-core Build #5116 succeeded in 2 min 12 sec
Details
continuous-integration/php-5.4 Build #5432 succeeded in 4 min 58 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #63304 succeeded in 1 min 4 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #32199 succeeded in 13 min
Details
core-ci-linux/database=oci,label=SLAVE Build #32199 succeeded in 55 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #32199 succeeded in 15 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #32199 succeeded in 6 min 3 sec
Details
ocs-api-integration-tests-ci Build #11999 succeeded in 7 min 46 sec
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11472 succeeded in 1 min 57 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11472 succeeded in 11 min
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #23455 succeeded in 2 min 45 sec
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40530 succeeded in 4 min 10 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 14 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 17 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 43 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 25 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 1 hr 7 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 36 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15787 succeeded in 33 min
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9-fix-ldap-check-user branch Jul 4, 2016
@PVince81
Collaborator
PVince81 commented Jul 4, 2016

Requires PRs for stable9.1 and master

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 4, 2016
@DeepDiver1975
Member

Requires PRs for stable9.1 and master

on it

@PVince81
Collaborator
PVince81 commented Jul 4, 2016

We might also want to backport to 8.2 ? (depending when that command was introduced)

@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Jul 4, 2016
@felixboehm @DeepDiver1975 felixboehm + DeepDiver1975 check if renamed user is still valid by reapplying the ldap filter (#… aa42d60
@DeepDiver1975
Member
DeepDiver1975 commented Jul 4, 2016 edited

master #25344
stable9.2: #25347

@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Jul 4, 2016
@felixboehm @DeepDiver1975 felixboehm + DeepDiver1975 check if renamed user is still valid by reapplying the ldap filter (#… 325776e
@SergioBertolinSG
Member

Stable8.2 is affected.

@PVince81
Collaborator
PVince81 commented Jul 5, 2016

@DeepDiver1975 can you also submit a backport to 8.2 ?

@SergioBertolinSG
Member

Stable8.1 affected as well.

@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Jul 6, 2016
@felixboehm @DeepDiver1975 felixboehm + DeepDiver1975 [stable8.2] check if renamed user is still valid by reapplying the ld…
…ap filter (#25338)
648afa8
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Jul 6, 2016
@felixboehm @DeepDiver1975 felixboehm + DeepDiver1975 [stable8.1] check if renamed user is still valid by reapplying the ld…
…ap filter (#25338)
19b34b5
@DeepDiver1975
Member

backports have been prepared

@PVince81
Collaborator
PVince81 commented Jul 7, 2016

stable8.2: #25394
stable8.1: #25393

@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Aug 10, 2016
@DeepDiver1975 DeepDiver1975 [stable8.2] check if renamed user is still valid by reapplying the ld… (
#25394)

* [stable8.2] check if renamed user is still valid by reapplying the ldap filter (#25338)

* Add missing filter during cleanup

* Fix another missing check
accf28a
@PVince81 PVince81 added a commit that referenced this pull request Aug 11, 2016
@felixboehm @PVince81 felixboehm + PVince81 [stable8.1] check if renamed user is still valid by reapplying the ld…
…ap filter (#25338)
fabb3fa
@PVince81 PVince81 added a commit that referenced this pull request Aug 18, 2016
@felixboehm @PVince81 felixboehm + PVince81 [stable8.1] check if renamed user is still valid by reapplying the ld…
…ap filter (#25338)
afe9f02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment