Files_Versions don't show when the files are erased #25367

Merged
merged 1 commit into from Jul 6, 2016

Projects

None yet

7 participants

@cdamken
Contributor
cdamken commented Jul 5, 2016

Upgrading the log level From Debug to INFO to be consistent with files_trashbin

@cdamken cdamken Upgrading the log level From Debug to INFO to be consistent with file…
…s_trashbin
9d60ccb
@mention-bot

@cdamken, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @bartv2 and @VicDeo to be potential reviewers

@felixboehm
Contributor

👍

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Jul 5, 2016
@DeepDiver1975
Member

👍

@DeepDiver1975
Member

@cdamken Thanks a lot for your contribution!

Does this fix any issue here on github? Please reference.

please submit PRs for stable9.1 und stable9 branches - THX

@cdamken
Contributor
cdamken commented Jul 5, 2016

Does this fix any issue here on github? Please reference.

It does not fix the issue, but I'm working in owncloud/enterprise#1279 and I saw that I have logs from the files_trashbin but none from files_versions

This probably will help me to monitor the cleanup in the cronjob

This was referenced Jul 5, 2016
@cdamken
Contributor
cdamken commented Jul 5, 2016

Not sure if I did it right but:
For 9.0 - #25370
For 9.1 - #25369

@DeepDiver1975 DeepDiver1975 merged commit 9c9062c into master Jul 6, 2016

21 of 24 checks passed

core-ci-linux-php7.1/database=sqlite,label=SLAVE continuous-integration/php-7.1
Details
server-master-linux-externals-smb-windows-ext-ci/database=sqlite,external=smb-windows,label=master Build #23711 failed in 52 sec
Details
core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #57273 in progress...
Details
Scrutinizer 3 new issues
Details
cla-bot-core Build #5150 succeeded in 1 min 0 sec
Details
continuous-integration/php-5.4 Build #5495 succeeded in 5 min 24 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #63360 succeeded in 48 sec
Details
core-ci-linux/database=mysql,label=SLAVE Build #32253 succeeded in 11 min
Details
core-ci-linux/database=oci,label=SLAVE Build #32253 succeeded in 28 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #32253 succeeded in 11 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #32253 succeeded in 6 min 3 sec
Details
ocs-api-integration-tests-ci Build #12044 succeeded in 1 hr 12 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11514 succeeded in 1 min 39 sec
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11514 succeeded in 8 min 2 sec
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11514 succeeded in 10 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #40588 succeeded in 3 min 34 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=litmus,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 7 min 1 sec
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@0,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 11 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_basicSync@1,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 29 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_shareLink,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 21 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePermissions,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 39 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationGroups,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 27 min
Details
smashbox-on-docker-ci/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v2.0.2,slave=SMASH Build #15829 succeeded in 24 min
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9-fix-version-log branch Jul 6, 2016
@PVince81
Collaborator
PVince81 commented Jul 6, 2016

@cdamken you need to create a new branch before doing the backport PR.
Start with stable9.1, create a branch, put your fix on it (git cherry-pick or patch it), then push, then submit a PR from that branch to stable9.1.

It looks like you tried to submit a PR directly from the master branch, which is wrong.
Let me know if you need help on IRC #owncloud-dev

@PVince81
Collaborator
PVince81 commented Jul 6, 2016

@cdamken thanks for the backports. We also need one to stable9.1. (master is 9.2)

@cdamken
Contributor
cdamken commented Jul 6, 2016

@PVince81 I think I committed that yesterday:

19cf727

But I'm not sure what I did 😄 I never used Sourcetree before. @michaelstingl Just show me how to use it.

Should I do it again?

@VicDeo
Member
VicDeo commented Jul 6, 2016 edited

@cdamken no, thanks
here it is
stable9.1: #25377

UPD. Nope, it seems to be commited directly to 9.1 branch

@michaelstingl

@cdamken overestimates his powers – he thinks he is Chuck Norris and don't need to do pr's 😆

@cdamken
Contributor
cdamken commented Jul 6, 2016

🙈 Ups I did't again!

@PVince81 do you remember I did that b4 😈

I will do it in the future like a normal person :)

@DeepDiver1975
Member

backport are done to all stable branches afaik

@PVince81
Collaborator
PVince81 commented Jul 7, 2016

@cdamken yes, don't be Chuck Norris.

@GitHubUser4234 GitHubUser4234 pushed a commit to GitHubUser4234/core that referenced this pull request Jul 22, 2016
@cdamken @DeepDiver1975 cdamken + DeepDiver1975 Upgrading the log level From Debug to INFO to be consistent with file…
…s_trashbin (#25367)
d58e6b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment