DAV: Return data-fingerprint always when asked #25482

Merged
merged 1 commit into from Aug 13, 2016

Projects

None yet

4 participants

@guruz
Contributor
guruz commented Jul 14, 2016

For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.

@guruz guruz added the enhancement label Jul 14, 2016
@guruz guruz added this to the 9.1.1 milestone Jul 14, 2016
@mention-bot

@guruz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @PVince81 and @DeepDiver1975 to be potential reviewers

@guruz
Contributor
guruz commented Jul 14, 2016

FYI @ogoffart

@PVince81 PVince81 commented on the diff Jul 15, 2016
apps/dav/lib/Connector/Sabre/FilesPlugin.php
}
- if ($node instanceof \OCA\DAV\Files\FilesHome) {
+ if ($node instanceof \OCA\DAV\Connector\Sabre\Node
+ || $node instanceof \OCA\DAV\Files\FilesHome) {
@PVince81
PVince81 Jul 15, 2016 Collaborator

I'm surprised that FilesHome isn't a Sabre\Node ?

@guruz
guruz Jul 15, 2016 Contributor

I was too ;)

@DeepDiver1975
DeepDiver1975 Jul 15, 2016 Member

FileHome implements ICollection
ICollection extends INode

@guruz
guruz Jul 15, 2016 Contributor

The if where I moved it out is \OCA\DAV\Connector\Sabre\Node not INode..

@PVince81
Collaborator

Looks good 👍

(don't merge before 9.1.1)

@guruz @PVince81 guruz DAV: Return data-fingerprint always when asked
For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.
15cfd49
@PVince81
Collaborator
PVince81 commented Aug 11, 2016 edited
  • Forward port to master

@ogoffart @DeepDiver1975 second review ?

Rebased to kick Jenkins

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 4033a6b into stable9.1 Aug 13, 2016

2 of 4 checks passed

Jenkins This pull request is scheduled to be built
Details
continuous-integration/jenkins/pr This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the data_finger_print_for_all branch Aug 13, 2016
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Aug 13, 2016
@guruz @DeepDiver1975 guruz + DeepDiver1975 [master] DAV: Return data-fingerprint always when asked (#25482)
For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.
82ddb09
@DeepDiver1975
Member

master: #25794

@mrow4a mrow4a added a commit that referenced this pull request Aug 18, 2016
@guruz @mrow4a guruz + mrow4a [master] DAV: Return data-fingerprint always when asked (#25482)
For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.
4006ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment