Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV: Return data-fingerprint always when asked #25482

Merged
merged 1 commit into from Aug 13, 2016

Conversation

@guruz
Copy link
Contributor

commented Jul 14, 2016

For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.

@guruz guruz added the enhancement label Jul 14, 2016
@guruz guruz added this to the 9.1.1 milestone Jul 14, 2016
@mention-bot

This comment has been minimized.

Copy link

commented Jul 14, 2016

@guruz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @PVince81 and @DeepDiver1975 to be potential reviewers

@guruz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2016

FYI @ogoffart

}
if ($node instanceof \OCA\DAV\Files\FilesHome) {
if ($node instanceof \OCA\DAV\Connector\Sabre\Node
|| $node instanceof \OCA\DAV\Files\FilesHome) {

This comment has been minimized.

Copy link
@PVince81

PVince81 Jul 15, 2016

Member

I'm surprised that FilesHome isn't a Sabre\Node ?

This comment has been minimized.

Copy link
@guruz

guruz Jul 15, 2016

Author Contributor

I was too ;)

This comment has been minimized.

Copy link
@DeepDiver1975

DeepDiver1975 Jul 15, 2016

Member

FileHome implements ICollection
ICollection extends INode

This comment has been minimized.

Copy link
@guruz

guruz Jul 15, 2016

Author Contributor

The if where I moved it out is \OCA\DAV\Connector\Sabre\Node not INode..

@PVince81

This comment has been minimized.

Copy link
Member

commented Jul 15, 2016

Looks good 👍

(don't merge before 9.1.1)

For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.
@PVince81 PVince81 force-pushed the data_finger_print_for_all branch from b209ceb to 15cfd49 Aug 11, 2016
@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

  • Forward port to master

@ogoffart @DeepDiver1975 second review ?

Rebased to kick Jenkins

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Aug 13, 2016

👍

@DeepDiver1975 DeepDiver1975 merged commit 4033a6b into stable9.1 Aug 13, 2016
2 of 4 checks passed
2 of 4 checks passed
Jenkins This pull request is scheduled to be built
Details
continuous-integration/jenkins/pr This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the data_finger_print_for_all branch Aug 13, 2016
DeepDiver1975 added a commit that referenced this pull request Aug 13, 2016
For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.
@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Aug 13, 2016

master: #25794

PVince81 added a commit that referenced this pull request Aug 16, 2016
…730ed2353f457f9aa9

[master] DAV: Return data-fingerprint always when asked (#25482)
@lock

This comment has been minimized.

Copy link

commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.