Prevent setting email and triggering events at login time #25553

Merged
merged 1 commit into from Jul 26, 2016

Projects

None yet

3 participants

@PVince81
Collaborator

Whenever an LDAP user also has an email address defined in LDAP, the
LDAP code will try and update the email address of the locally known
user. This happens at login time or every time the user's LDAP
attributes are processed.

There is code listening to the email setting hook which updates the
system address book, which also will trigger FS setup due to avatars
and other things.

This fix only sets the email address when really necessary.

Fixes #25511

Please review @owncloud/ldap @DeepDiver1975 @georgehrke

@PVince81 PVince81 Prevent setting email and triggering events at login time
Whenever an LDAP user also has an email address defined in LDAP, the
LDAP code will try and update the email address of the locally known
user. This happens at login time or every time the user's LDAP
attributes are processed.

There is code listening to the email setting hook which updates the
system address book, which also will trigger FS setup due to avatars
and other things.

This fix only sets the email address when really necessary.
94a7cdc
@PVince81 PVince81 added this to the 9.2 milestone Jul 21, 2016
@mention-bot

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @blizzz and @nickvergessen to be potential reviewers

@PVince81
Collaborator
PVince81 commented Jul 21, 2016 edited
@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit fb0a717 into master Jul 26, 2016

14 of 18 checks passed

core-ci-linux-swift-primary-storage/database=mysql,label=SLAVE Build #57671 failed in 1 hr 24 min
Details
Jenkins job ldap-avoidneedlesssetemailonlogin This commit cannot be built
Details
server-master-linux-externals-ci/database=sqlite,external=smb-windows,label=SLAVE Build #11894 found unstable in 22 min
Details
Jenkins job PR-25553 This commit is being built
Details
Scrutinizer 1 updated code elements
Details
cla-bot-core Build #5413 succeeded in 24 min
Details
continuous-integration/php-5.4 Build #6037 succeeded in 29 min
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
core-ci-linux-jsunit/database=sqlite,label=SLAVE Build #63777 succeeded in 22 min
Details
core-ci-linux/database=mysql,label=SLAVE Build #32626 succeeded in 1 hr 23 min
Details
core-ci-linux/database=oci,label=SLAVE Build #32625 succeeded in 3 hr 38 min
Details
core-ci-linux/database=pgsql,label=SLAVE Build #32626 succeeded in 1 hr 45 min
Details
core-ci-linux/database=sqlite,label=SLAVE Build #32626 succeeded in 22 min
Details
ocs-api-integration-tests-ci Build #12351 succeeded in 13 min
Details
server-master-linux-externals-ci/database=sqlite,external=smb-silvershell,label=SLAVE Build #11894 succeeded in 12 min
Details
server-master-linux-externals-ci/database=sqlite,external=swift-ceph,label=SLAVE Build #11894 succeeded in 20 min
Details
server-master-linux-externals-ci/database=sqlite,external=webdav-ownCloud,label=SLAVE Build #11894 succeeded in 20 min
Details
server-master-linux-php7-ci/database=sqlite,label=SLAVE Build #41014 succeeded in 20 min
Details
@DeepDiver1975 DeepDiver1975 deleted the ldap-avoidneedlesssetemailonlogin branch Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment