Skip version and trash expiry for users that never logged in #25741

Merged
merged 1 commit into from Aug 10, 2016

Projects

None yet

5 participants

@butonic
Member
butonic commented Aug 9, 2016

it saves us trying to set up the filesystem

@butonic butonic Skip version and trash expiry for users that never logged in
4777d6a
@mention-bot

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @VicDeo, @nickvergessen and @LukasReschke to be potential reviewers

@butonic butonic added this to the 9.2 milestone Aug 9, 2016
@DeepDiver1975
Member

👍

@VicDeo
Member
VicDeo commented Aug 10, 2016

👍

@DeepDiver1975 DeepDiver1975 merged commit 099216a into master Aug 10, 2016

3 of 4 checks passed

Jenkins This commit cannot be built
Details
Scrutinizer 158 new issues, 65 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the skip_expiry_for_users_that_never_logged_in branch Aug 10, 2016
@VicDeo
Member
VicDeo commented Aug 10, 2016

Stable9.1: #25745
Stable9: #25742

@mrow4a
Contributor
mrow4a commented Aug 11, 2016 edited

@butonic @DeepDiver1975 Lets go back to this pull request and instead of again asking each LDAP users, maybe lets inplement in userManager function callForOCUsers, which will loop through users which loged at least once. Currently is calling for everyone and asking, which still is performance weak.

@DeepDiver1975
Member

Lets go back to this pull request and instead of again asking each LDAP users, maybe lets inplement in userManager function callForOCUsers, which will loop through users which loged at least once.

this is the idea of the user account table which will be the only central store where all users are listed in.
This is a topic which We can hopefully battle in 9.2 ......

@mrow4a
Contributor
mrow4a commented Aug 11, 2016

Can? We must :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment