lastInsertId requires the prefix #25764

Merged
merged 1 commit into from Aug 12, 2016

Projects

None yet

4 participants

@butonic
Member
butonic commented Aug 10, 2016 edited

otherwise we get a "sequence does not exist error" on oracle. just check all other occurences of lastInsertId.
without this files_external is broken on oracle

@mention-bot

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @nickvergessen and @Xenopathic to be potential reviewers

@butonic butonic added this to the 9.2 milestone Aug 10, 2016
@butonic
Member
butonic commented Aug 10, 2016

cc @PVince81 because he wanted me to give him oracle

@DeepDiver1975
Member

Just another case where unit testing would have helped.

@butonic butonic lastInsertId requires the prefix
6b3c653
@PVince81
Collaborator

@butonic any chance to add a quick unit test for this ? Even if it just calls the method with a single test case, just to give it a pass.

@PVince81
Collaborator

πŸ‘ otherwise

@DeepDiver1975
Member

@butonic backport?

@butonic
Member
butonic commented Aug 12, 2016

@PVince81 there are tests that cover this method: https://github.com/owncloud/core/blob/master/apps/files_external/tests/Service/DBConfigServiceTest.php#L66

But I assume that our files external tests only run on sqlite or mysql ... @DeepDiver1975 ?

I'll create backports.

@butonic butonic added a commit that referenced this pull request Aug 12, 2016
@butonic butonic [stable9.1] lastInsertId requires the prefix
backport of #25764
c14d45f
@butonic butonic added a commit that referenced this pull request Aug 12, 2016
@butonic butonic [stable9] lastInsertId requires the prefix
backport of #25764
64b4e03
@DeepDiver1975
Member

But I assume that our files external tests only run on sqlite or mysql ... @DeepDiver1975 ?

yes indeed - bloody hell .... let's ignore for now - @PVince81 will move this code to core anyhow within 9.2

@DeepDiver1975 DeepDiver1975 merged commit 460a772 into master Aug 12, 2016

3 of 5 checks passed

Jenkins This commit is being built
Details
continuous-integration/jenkins/pr This commit is being built
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the missingprefixforlastinsertid branch Aug 12, 2016
@nickvergessen nickvergessen referenced this pull request in nextcloud/server Aug 15, 2016
Merged

Fix oracle support of external storage app #870

@LukasReschke LukasReschke added a commit to nextcloud/server that referenced this pull request Aug 29, 2016
@butonic @LukasReschke butonic + LukasReschke [stable9] lastInsertId requires the prefix (#25786) 11fe503
@LukasReschke LukasReschke added a commit to nextcloud/server that referenced this pull request Aug 29, 2016
@butonic @LukasReschke butonic + LukasReschke [stable9.1] lastInsertId requires the prefix (#25785) b81c74a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment