Fix hidden files handling #25856

Merged
merged 1 commit into from Aug 19, 2016

Projects

None yet

2 participants

@PVince81
Collaborator

Hidden files (dot files) are now always rendered in the DOM to make
sure that all file operations and selection still work as expected.

Their visibility is now toggled on CSS level.

Fixes #25309
Fixes #25680

@SergioBertolinSG will need some thorough testing to see if all functionality still works.
Note that if you select all files with the special checkbox, the hidden files are selected too and also affected by "delete all".

The only part I'm not too happy about is the summary, raised here #25855

@PVince81 PVince81 Fix hidden files handling
Hidden files (dot files) are now always rendered in the DOM to make
sure that all file operations and selection still work as expected.

Their visibility is now toggled on CSS level.
0089850
@PVince81 PVince81 added this to the 9.1.1 milestone Aug 18, 2016
@PVince81 PVince81 added the sev2-high label Aug 18, 2016
@PVince81
Collaborator

I'd like to get this into 9.1.1 because if you happen to have hidden files the files app doesn't behave properly.

CC @DeepDiver1975

@PVince81
Collaborator
  • TEST: show hidden files
  • TEST: hide hidden files
  • TEST: hide hidden files, then select all, drag and drop into another folder in breadcrumb
  • TEST: hide hidden files, then select all, delete => all in trash
  • TEST: hide hidden files, then select all, download => all present in zip
@PVince81
Collaborator
  • TEST: nextPage call after hiding hidden files
  1. Show hidden files
  2. Create 20 visible folders and 10 visible folders. Goal is to create a situation that requires scroll down to show the next page
  3. Refresh the page to have only the first page loaded
  4. Hide hidden files: this will create a gap that will be filled by automatic loading of next page
@SergioBertolinSG
Member

Tested #25680 here, works fine 👍

@PVince81 PVince81 merged commit 4d7e803 into master Aug 19, 2016

4 checks passed

Scrutinizer 2 new issues
Details
continuous-integration/jenkins/pr This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the files-render-hidden-files-hidden branch Aug 19, 2016
@PVince81
Collaborator

stable9.1: #25865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment