Best practice through out the web speak of a max avatar image size of… #25857

Merged
merged 2 commits into from Aug 22, 2016

Projects

None yet

4 participants

@DeepDiver1975
Member
DeepDiver1975 commented Aug 18, 2016 edited

… 96 pixels

@felixboehm

fixes #25730
fixes #24488

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 18, 2016
@mention-bot

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 to be a potential reviewer

@DeepDiver1975 DeepDiver1975 Best practice through out the web speak of a max avatar image size of…
… 96 pixels
ba75ef3
@PVince81
Collaborator

Will this work on the personal page in the avatar cropping dialog ? I believe it might be using this code path.

@PVince81
Collaborator

Never mind, I thought it was a different code path.

👍

@DeepDiver1975 DeepDiver1975 Respect size argument
99131df
@PVince81
Collaborator

👍 for the extra change, avatar still seems to work fine (LDAP, personal page)

@felixboehm
Contributor

top 👍

@DeepDiver1975 DeepDiver1975 merged commit a9e633d into master Aug 22, 2016

4 checks passed

Scrutinizer 2 new issues, 2 updated code elements
Details
continuous-integration/jenkins/pr This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the reduce-avatar-size-on-vcard branch Aug 22, 2016
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 22, 2016
@DeepDiver1975
Member

preparing backports ...

@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Aug 22, 2016
@DeepDiver1975 @DeepDiver1975 DeepDiver1975 + DeepDiver1975 [stable9.1] Best practice through out the web speak of a max avatar i…
…mage size of… (#25857)

* Best practice through out the web speak of a max avatar image size of 96 pixels

* Respect size argument

THX @felixboehm
4c7135a
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Aug 22, 2016
@DeepDiver1975 @DeepDiver1975 DeepDiver1975 + DeepDiver1975 [9.0] Best practice through out the web speak of a max avatar image s…
…ize of… (#25857)

* Best practice through out the web speak of a max avatar image size of 96 pixels

* Respect size argument

THX @felixboehm
17f0626
@DeepDiver1975
Member
DeepDiver1975 commented Aug 22, 2016 edited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment