Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA can now be enabled and disabled via the provisioning api #25876

Merged
merged 1 commit into from Aug 22, 2016

Conversation

@DeepDiver1975
Copy link
Member

commented Aug 19, 2016

@hodyroff

@carlaschroder we need to add this to the provisioning api docs for 9.2 and 9.1

@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

@DeepDiver1975 what's the test command ?
I scrolled through the diff twice and all I see is "Result", "Result", "Result", "Result", ... and one injected two factor provider. Mind pointing to the place where the command was modified ?

@DeepDiver1975

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

Mind pointing to the place where the command was modified ?

https://github.com/owncloud/core/pull/25876/files#diff-b883261d8003d06c420013ab69dbc6a6R302

@DeepDiver1975

This comment has been minimized.

@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

Tested:

  1. Enable two factor app
  2. Disable two factor for the admin on the CLI: ./occ twofactorauth:disable admin (else the provisioning API doesn't work, alternative is to create a token)
  3. Create a user "user1"
  4. curl -X PUT --user admin:admin "http://localhost/owncloud/ocs/v1.php/cloud/users/user1" -d key="two_factor_auth_enabled" -d value="false"
  5. Check the user state: curl -X GET --user admin:admin http://localhost/owncloud/ocs/v1.php/cloud/users/user1
<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>100</statuscode>
  <message/>
 </meta>
 <data>
  <enabled>true</enabled>
  <quota/>
  <email/>
  <displayname>user1</displayname>
  <two_factor_auth_enabled></two_factor_auth_enabled>
 </data>
</ocs>

When enabled it shows as 1.

👍 works

@PVince81 PVince81 merged commit e67c564 into master Aug 22, 2016
4 checks passed
4 checks passed
Scrutinizer 6 new issues, 1 updated code elements
Details
continuous-integration/jenkins/pr This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the provisioning_2fa branch Aug 22, 2016
@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

@DeepDiver1975 please submit backport PR for 9.1.1

@DeepDiver1975

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

When enabled it shows as 1.

hmmmm - shouldn't it be a proper true and false?

@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 22, 2016

This is what I saw when getting the user:

  % curl -X GET --user admin:admin http://localhost/owncloud/ocs/v1.php/cloud/users
<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>100</statuscode>
  <message/>
 </meta>
 <data>
  <enabled>true</enabled>
  <quota/>
  <email/>
  <displayname>user1</displayname>
  <two_factor_auth_enabled>1</two_factor_auth_enabled>
 </data>
</ocs>
@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 23, 2016

@DeepDiver1975 please backport and include #25908

@DeepDiver1975

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2016

@DeepDiver1975 please backport and include #25908

done - #25911

@lock

This comment has been minimized.

Copy link

commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.