Fix empty PATH_INFO #25893

Merged
merged 1 commit into from Aug 22, 2016

Projects

None yet

3 participants

@DeepDiver1975
Member

fixes nextcloud/twofactor_totp#29

@elie195 this should also fix your issue as reported in https://github.com/elie195/duo_provider#notes

@DeepDiver1975 DeepDiver1975 Fix empty PATH_INFO
b99a376
@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 22, 2016
@mention-bot

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @tanghus and @Xenopathic to be potential reviewers

@PVince81
Collaborator

Couldn't reproduce the original issue, but fix looks fine πŸ‘

@DeepDiver1975
Member

Couldn't reproduce the original issue

you need to

  • enable any twofactor app - e.g. the one by @ChristophWurst and enable it for the user
  • enable notifications
  • run owncloud in apache
  • setup index.php-less urls

then you can observe the reload on the two factor selection page already

@PVince81
Collaborator

setup index.php-less urls

ah, was missing that. Will try again

@PVince81
Collaborator

Was able to reproduce the issue and can confirm that this fixes it.

@ChristophWurst ChristophWurst referenced this pull request in nextcloud/twofactor_totp Aug 22, 2016
Closed

Reloads every 5 seconds #29

@PVince81
Collaborator

Unpublished test results that passed => merge

@PVince81 PVince81 merged commit b75a3cb into master Aug 22, 2016

3 of 4 checks passed

continuous-integration/jenkins/pr This commit is being built
Details
Scrutinizer 9 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the fix-notification-reload branch Aug 22, 2016
@PVince81
Collaborator

@DeepDiver1975 please submit the backport PR

@DeepDiver1975
Member
DeepDiver1975 commented Aug 22, 2016 edited

@DeepDiver1975 please submit the backport PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment