New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2] Show avatar in share drop down #25976

Merged
merged 2 commits into from Oct 6, 2016

Conversation

Projects
None yet
3 participants
@DeepDiver1975
Member

DeepDiver1975 commented Aug 29, 2016

Description

The share dropdow now shows the avatar of the user.
TODO:

  • add avatar of a remote user

Screenshots (if appropriate):

bildschirmfoto von 2016-08-30 00-40-46

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 29, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 29, 2016

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @PVince81 and @nickvergessen to be potential reviewers

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @PVince81 and @nickvergessen to be potential reviewers

Show outdated Hide outdated core/css/share.css
display: flex;
}
.autocomplete-item-text {
margin: 10px;

This comment has been minimized.

@PVince81

PVince81 Oct 5, 2016

Member

DUDE, that's now how you center text vertically 😉

@PVince81

PVince81 Oct 5, 2016

Member

DUDE, that's now how you center text vertically 😉

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 5, 2016

Member

Looks good so far, let me see if I can center all the things properly

Member

PVince81 commented Oct 5, 2016

Looks good so far, let me see if I can center all the things properly

Show outdated Hide outdated core/css/share.css
@@ -50,6 +50,13 @@
height: 32px;
}
.autocomplete-item {

This comment has been minimized.

@PVince81

PVince81 Oct 5, 2016

Member

global namespace pollution, is likely to disturb other autocomplete boxes. let's see if we can give that specific autocomplete an additional class

@PVince81

PVince81 Oct 5, 2016

Member

global namespace pollution, is likely to disturb other autocomplete boxes. let's see if we can give that specific autocomplete an additional class

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 5, 2016

Member

Fixed alignment, looks good now 👍

@DeepDiver1975 please review my changes.
For the remote avatar stuff, let's do it separately and merge this!

Member

PVince81 commented Oct 5, 2016

Fixed alignment, looks good now 👍

@DeepDiver1975 please review my changes.
For the remote avatar stuff, let's do it separately and merge this!

@DeepDiver1975 DeepDiver1975 merged commit 9fd9a01 into master Oct 6, 2016

3 of 5 checks passed

Scrutinizer Errored
Details
VersionEye Some dependencies have no license.
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the sharing-avatars branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment