fix public calendars #26112
Merged
fix public calendars #26112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcitworld, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @nickvergessen and @LukasReschke to be potential reviewers |
| */ | ||
| public function getPublishToken($calendar) { | ||
| $query = $this->db->getQueryBuilder(); | ||
| $result = $query->select('publicuri') |
There was a problem hiding this comment.
I'd prefer to add this to the overall loading query where we already join calendar table with the shares table
There was a problem hiding this comment.
Workaround. Not the best, but only one request.
tcitworld
force-pushed
the
fix-public-calendars
branch
from
d28692e
to
7dc37ea
Compare
|
Tested - works 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes public calendars work properly again.
I have made that quite simply, but maybe it's better to wrap this all in a PublicCalendar class ?
Related Issue
#22735
Types of changes
Checklist: