[stable9] Tear down FS after user update in CardDAV sync job #26204

Merged
merged 1 commit into from Oct 8, 2016

Projects

None yet

3 participants

@PVince81
Collaborator
PVince81 commented Sep 23, 2016 edited

Description

Tear down FS after user update in CardDAV sync job

Related Issue

Discovered by analyzing #25718 (comment)

Motivation and Context

Because fetching the user information will also fetch the avatar, the
avatar code sets up the FS and leaves the mount points cached, we need
to call tearDownFS to clear that up.

This should also significantly reduce memory usage when processing many users.

How Has This Been Tested?

Tested with a debugger. Checked with a breakpoint in tearDownFS and checked that the $mounts local attribute only ever contains the mounts of the last user and not everything.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Ports

  • forward port to 9.1
  • forward port to master

@butonic @DeepDiver1975 as discussed

@PVince81 PVince81 Tear down FS after user update in CardDAV sync job
Because fetching the user information will also fetch the avatar, the
avatar code sets up the FS and leaves the mount points cached, we need
to call tearDownFS to clear that up.
7cf9394
@PVince81 PVince81 added this to the 9.0.6 milestone Sep 23, 2016
@mention-bot

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @schiessle and @LukasReschke to be potential reviewers

@PVince81
Collaborator
PVince81 commented Oct 5, 2016

I still think we should merge this to save some memory @DeepDiver1975 @butonic

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 12c934a into stable9 Oct 8, 2016

3 of 4 checks passed

VersionEye Some dependencies have no license.
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9-teardownincarddavsyncjob branch Oct 8, 2016
@PVince81
Collaborator

stable9.1: #26320
master: #26321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment