Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate file summary connector #26221

Merged
merged 1 commit into from Sep 27, 2016
Merged

Conversation

@PVince81
Copy link
Member

PVince81 commented Sep 27, 2016

Description

Translate " and " in file summary.

Related Issue

Motivation and Context

How Has This Been Tested?

Switch the language to french or german, create a file and folder and see that the connector is in the summary translated again instead of saying " and "

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @ppaysant @davitol @DeepDiver1975

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Sep 27, 2016

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @butonic, @DeepDiver1975 and @vgezer to be potential reviewers

@PVince81 PVince81 added this to the 9.2 milestone Sep 27, 2016
@PVince81

This comment has been minimized.

Copy link
Member Author

PVince81 commented Sep 27, 2016

should be backported to 9.1 where the refactoring with the template was introduced

@davitol

This comment has been minimized.

Copy link
Contributor

davitol commented Sep 27, 2016

👍 WFM

@ppaysant

This comment has been minimized.

Copy link
Contributor

ppaysant commented Sep 27, 2016

Tested, works for me 👍

@DeepDiver1975 DeepDiver1975 merged commit d306e36 into master Sep 27, 2016
3 of 5 checks passed
3 of 5 checks passed
VersionEye Some dependencies have no license.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the files-translate-filesummary branch Sep 27, 2016
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 27, 2016
DeepDiver1975 added a commit that referenced this pull request Sep 27, 2016
@DeepDiver1975

This comment has been minimized.

Copy link
Member

DeepDiver1975 commented Sep 27, 2016

9.1: #26222

@lock

This comment has been minimized.

Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.