[stable9.1] Tear down FS between cron jobs #26223

Merged
merged 1 commit into from Sep 30, 2016

Projects

None yet

3 participants

@PVince81
Collaborator
PVince81 commented Sep 27, 2016 edited

Description

Because some cron jobs do not always properly clean up their FS usage
and others might not clean up before setting up the FS, this could
cause potential side effects.

To make sure we exclude side effects, we tear down the FS between cron
jobs.

Related Issue

Tentative fix for #25718

Motivation and Context

See issue details

How Has This Been Tested?

Ran cron.php and saw there was no new errors.
Note that the original issue isn't reproducible yet, so this is just an extra care.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Backports

  • forward port to master
  • all other stable branches ?

@DeepDiver1975 @butonic

@PVince81 PVince81 Tear down FS between cron jobs
Because some cron jobs do not always properly clean up their FS usage
and others might not clean up before setting up the FS, this could
cause potential side effects.

To make sure we exclude side effects, we tear down the FS between cron
jobs.
2dd9ab4
@PVince81 PVince81 added this to the 9.1.2 milestone Sep 27, 2016
@mention-bot

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @butonic and @nickvergessen to be potential reviewers

@PVince81
Collaborator
  • also do this between repair steps, just in case (the FS stuff being so messy that we better be sure)
@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 8b20b12 into stable9.1 Sep 30, 2016

3 of 4 checks passed

VersionEye Some dependencies have no license.
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9.1-teardownfsaftercronjob branch Sep 30, 2016
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Sep 30, 2016
@PVince81 @DeepDiver1975 PVince81 + DeepDiver1975 [master] Tear down FS between cron jobs (#26223)
Because some cron jobs do not always properly clean up their FS usage
and others might not clean up before setting up the FS, this could
cause potential side effects.

To make sure we exclude side effects, we tear down the FS between cron
jobs.
5df076b
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Sep 30, 2016
@PVince81 @DeepDiver1975 PVince81 + DeepDiver1975 [stable9] Tear down FS between cron jobs (#26223)
Because some cron jobs do not always properly clean up their FS usage
and others might not clean up before setting up the FS, this could
cause potential side effects.

To make sure we exclude side effects, we tear down the FS between cron
jobs.
44aa9b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment