App dependencies are now analysed on app enable as well - not only on app install. #26295

Merged
merged 1 commit into from Oct 10, 2016

Projects

None yet

3 participants

@DeepDiver1975
Member

Description

App dependencies can now evaluated on enable as well.

Motivation and Context

Let's say the system environment was okay on installation of an app.
Then the app is disabled for some time and in between the system environment is changed.
After re-enabling the app we would render the system unstable.

How Has This Been Tested?

Add a dependency to an installed but disabled app - e.g.

    <database>mongodb</database>

Now enable the app and see it fail

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@DeepDiver1975 DeepDiver1975 App dependencies are now analysed on app enable as well - not only on…
… app install.
c6e47db
@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Oct 7, 2016
@mention-bot

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @icewind1991 and @nickvergessen to be potential reviewers.

@PVince81
Collaborator

Tested by enabling on the CLI with mismatch requirements because the web UI doesn't allow it. Works 👍
Also checked that master didn't do the check with "occ app:enable".

@PVince81 PVince81 merged commit 9eef6e5 into master Oct 10, 2016

4 of 5 checks passed

VersionEye Some dependencies have no license.
Details
Scrutinizer 1 new issues, 3 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the analyse-dependencies-on-app-enable-as-well branch Oct 10, 2016
@DeepDiver1975
Member

@PVince81 @butonic do we agree on backporting? THX

@PVince81
Collaborator

I'd say backport to 9.1 but no further, unless really critical

@DeepDiver1975 DeepDiver1975 self-assigned this Oct 10, 2016
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Oct 10, 2016
@PVince81 @DeepDiver1975 PVince81 + DeepDiver1975 [stable9.1] Merge pull request #26295 from owncloud/analyse-dependenc…
…ies-on-app-enable-as-well

App dependencies are now analysed on app enable as well - not only on app install.
d688b62
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Oct 12, 2016
@PVince81 @DeepDiver1975 PVince81 + DeepDiver1975 [stable9.1] Merge pull request #26295 from owncloud/analyse-dependenc…
…ies-on-app-enable-as-well

App dependencies are now analysed on app enable as well - not only on app install.
b504757
@DeepDiver1975 DeepDiver1975 added a commit that referenced this pull request Oct 13, 2016
@PVince81 @DeepDiver1975 PVince81 + DeepDiver1975 [stable9.1] Merge pull request #26295 from owncloud/analyse-dependenc…
…ies-on-app-enable-as-well

App dependencies are now analysed on app enable as well - not only on app install.
fe1806c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment