Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] New command to update group mappings #26343

Merged
merged 1 commit into from Oct 11, 2016

Conversation

jvillafanez
Copy link
Member

Description

New command to update LDAP group mappings

Related Issue

https://github.com/owncloud/enterprise/issues/1464
Backport of owncloud/user_ldap#14 to stable9

Motivation and Context

How Has This Been Tested?

Run the command against an LDAP server

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jvillafanez jvillafanez added this to the 9.0.6 milestone Oct 11, 2016
@mention-bot
Copy link

@jvillafanez, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @owncloud-bot and @DeepDiver1975 to be potential reviewers.

@DeepDiver1975 DeepDiver1975 changed the title New command to update group mappings [stable9] New command to update group mappings Oct 11, 2016
@PVince81
Copy link
Contributor

Doesn't seem to work, I have setup LDAP like I did for the master PR but the command says the groups are unknown:

± % occ ldap:update-group Box10 Box100
Group membership attribute is critical for this command, please verify.
* localhost:389 -> memberUid
Some of the groups are unknown

In the users page I can see these groups visible, so something must be wrong.

@PVince81
Copy link
Contributor

Both oc_ldap_group_mapping and oc_ldap_group_members contain entries.

@PVince81
Copy link
Contributor

Hmm, weird. I upgraded to master and it doesn't work there either.

@PVince81
Copy link
Contributor

Ohhh even stranger, the checkGroupMappingExists receives 2 results for the group which is not equal to the count of 1, so fails... But the entry only exists once in the DB.

@PVince81
Copy link
Contributor

Ah... I passed two groups on the CLI. One exists in the mapping but one doesn't... Ok, I should have read the error message properly. Turns out I deleted Box100 in a previous test run.

Will retest...

@PVince81
Copy link
Contributor

Works now 👍

@PVince81 PVince81 merged commit 8f39d01 into stable9 Oct 11, 2016
@PVince81 PVince81 deleted the ldap_command_updategroup_stable9 branch October 11, 2016 17:28
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants