[stable9.1] Fix post_unshareFromSelf hook parameter format #26390

merged 1 commit into from Oct 18, 2016


None yet

3 participants


Forward port of #26364 to stable9.1

@PVince81 PVince81 Fix post_unshareFromSelf hook parameter format
When unsharing from self in a group share situation, the share items
passed to the post_unshareFromSelf hook were using the wrong format in
which the attribute names (ex: "share_type") have non camel-case format.

This fix makes sure that in group sharing case we use the correct
format. It looks like the code was already producing it but in
array_merge it was not using it and adding the unprocessed one.
@PVince81 PVince81 added this to the 9.1.2 milestone Oct 17, 2016

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @rullzer and @nickvergessen to be potential reviewers.



@PVince81 PVince81 merged commit 1f49bf5 into stable9.1 Oct 18, 2016

3 checks passed

continuous-integration/jenkins/pr-head This commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.
@PVince81 PVince81 deleted the stable9.1-group-etagpropagation-test branch Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment