New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] Add Redis Cluster support #26407

Merged
merged 3 commits into from Mar 21, 2017

Conversation

Projects
None yet
8 participants
@DeepDiver1975
Member

DeepDiver1975 commented Oct 19, 2016

Description

Adding support for redis clustering
Restart of #23204

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Oct 19, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Oct 19, 2016

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @nickvergessen to be potential reviewers.

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @nickvergessen to be potential reviewers.

Show outdated Hide outdated lib/private/RedisFactory.php
throw new \Exception('Redis Cluster support is not available');
}
// cluster config
$timeout = isset($config['timeout']) ? $config['timeout'] : null;

This comment has been minimized.

@butonic

butonic Oct 19, 2016

Member

we are not using the ternary operator

@butonic

butonic Oct 19, 2016

Member

we are not using the ternary operator

This comment has been minimized.

@nickvergessen

nickvergessen Oct 19, 2016

Contributor

ternary has no isset support, so it can not be used in such cases

@nickvergessen

nickvergessen Oct 19, 2016

Contributor

ternary has no isset support, so it can not be used in such cases

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Nov 11, 2016

Member

Some notes for testing this:

with v2.2.8 and a small fix, see upstream doc example the PR works as expected! 👍

Member

butonic commented Nov 11, 2016

Some notes for testing this:

with v2.2.8 and a small fix, see upstream doc example the PR works as expected! 👍

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Nov 11, 2016

Member

@Ethendrel care to review? Then we can finally merge redis cluster support!

Member

butonic commented Nov 11, 2016

@Ethendrel care to review? Then we can finally merge redis cluster support!

@butonic butonic self-assigned this Nov 28, 2016

@DeepDiver1975 DeepDiver1975 changed the title from [9.2] Add Redis Cluster support to [10.0] Add Redis Cluster support Jan 31, 2017

Xenopathic and others added some commits Mar 13, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jan 31, 2017

Member

@owncloud/qa quick manual test and create plan to have automated tests for this ?

Member

PVince81 commented Jan 31, 2017

@owncloud/qa quick manual test and create plan to have automated tests for this ?

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Feb 7, 2017

Member

create plan to have automated tests for this

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

Member

DeepDiver1975 commented Feb 7, 2017

create plan to have automated tests for this

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

@tboerger

This comment has been minimized.

Show comment
Hide comment
@tboerger

tboerger Feb 24, 2017

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

Which kind of cluster? :)

our plans for the dockerized integration tests could help a lot here
@tboerger - can we haz a redis cluster docker-composer setup plez?

Which kind of cluster? :)

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Feb 24, 2017

Member

Which kind of cluster? :)

redis 😉

Member

DeepDiver1975 commented Feb 24, 2017

Which kind of cluster? :)

redis 😉

@tboerger

This comment has been minimized.

Show comment
Hide comment
@tboerger

tboerger Feb 24, 2017

redis 😉

Never used a redis cluster, so you want some sentinel based cluster?

redis 😉

Never used a redis cluster, so you want some sentinel based cluster?

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Feb 24, 2017

Member

@butonic please let @tboerger know what kind do of redis cluster we need

Member

DeepDiver1975 commented Feb 24, 2017

@butonic please let @tboerger know what kind do of redis cluster we need

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Feb 26, 2017

Member
Member

butonic commented Feb 26, 2017

@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Mar 21, 2017

Contributor

we can test this in 10.0.0beta with a customer, if we merge it for the beta release.
@PVince81

Contributor

pmaier1 commented Mar 21, 2017

we can test this in 10.0.0beta with a customer, if we merge it for the beta release.
@PVince81

@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Mar 21, 2017

Contributor

Please cover with dokcer reds cluster infrastructure for testing @tboerger

Contributor

pmaier1 commented Mar 21, 2017

Please cover with dokcer reds cluster infrastructure for testing @tboerger

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Mar 21, 2017

Member

we can test this in 10.0.0beta with GWDG, if we merge it for the beta release.

who can coordinate a test setup? @pmaier1

@PVince81 let's merge this one

Member

DeepDiver1975 commented Mar 21, 2017

we can test this in 10.0.0beta with GWDG, if we merge it for the beta release.

who can coordinate a test setup? @pmaier1

@PVince81 let's merge this one

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 21, 2017

Member

Ok then 👍

@DeepDiver1975 please add to the feature list in the wiki

Member

PVince81 commented Mar 21, 2017

Ok then 👍

@DeepDiver1975 please add to the feature list in the wiki

@DeepDiver1975 DeepDiver1975 merged commit ec9a9c9 into master Mar 21, 2017

4 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the redis-cluster-tom branch Mar 21, 2017

@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Mar 21, 2017

Contributor

who can coordinate a test setup? @pmaier1

I will coordinate this along with the beta.

Contributor

pmaier1 commented Mar 21, 2017

who can coordinate a test setup? @pmaier1

I will coordinate this along with the beta.

@MorrisJobke MorrisJobke referenced this pull request Mar 26, 2017

Merged

Redis cluster support #4061

0 of 1 task complete

@PVince81 PVince81 referenced this pull request Apr 7, 2017

Open

Test redis cluster #411

@PVince81

This comment has been minimized.

Show comment
Hide comment
Member

PVince81 commented Apr 7, 2017

QA ticket owncloud/QA#411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment