Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Display changes in file versions tab view and detailsView #26511
I made some changes to improve the file version tab.
Issue Tag: #26510
Motivation and Context
This pull requests contains code to view the version file size on the file version tab.
How Has This Been Tested?
The test was ok for the following browsers:
Screenshots (if appropriate):
Types of changes
Great PR, love it! Also works well.
There are a few minor issues, please see my review comments.
Would you mind adding the size field in the JS unit tests here https://github.com/owncloud/core/blob/v9.1.1/apps/files_versions/tests/js/versionstabviewSpec.js#L80 ?
It works but maybe ideally it would be great that the star will turn into yellow on mouse over as it happens in the files view. With this PR, the star keeps in grey. BTW it is a better behaviour than before. Great job!!
Can please someone tell me why chrome displays code different on OSX than on other OSs. Do you guys know a possibility how to test the code on OSX without apple hardware? I use a vm for tests on windows.
Thank you, I'm going to create another PR to cover your change requests regarding the color of the favorite star on hover and the JS unit test enhancements.
Added to features page: https://github.com/owncloud/core/wiki/ownCloud-9.2-Features