Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly convert OCS params + more tests #26691

Merged
merged 2 commits into from Nov 23, 2016

Conversation

@PVince81
Copy link
Member

commented Nov 22, 2016

PVince81 and others added 2 commits Nov 22, 2016
Added read and share permissions instead of all (default ones)

Added positive case

Check also permissions update

Added tests for resharing with public links when the user doesn't have enough permisssions
@mention-bot

This comment has been minimized.

Copy link

commented Nov 22, 2016

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @SergioBertolinSG and @DeepDiver1975 to be potential reviewers.

@PVince81 PVince81 changed the title Properly correct OCS params + more tests Properly convert OCS params + more tests Nov 22, 2016
@jvillafanez

This comment has been minimized.

Copy link
Member

commented Nov 23, 2016

👍

@PVince81 PVince81 merged commit 687c059 into master Nov 23, 2016
4 checks passed
4 checks passed
Scrutinizer 44 new issues, 308 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the publicupload-fix branch Nov 23, 2016
@PVince81 PVince81 self-assigned this Nov 23, 2016
@PVince81

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2016

stable9.1: #26694 #26716
stable9: #26696

@lock

This comment has been minimized.

Copy link

commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.