[stable9] Use the correct realm for basic authentication - fixes #23427 #26721

Merged
merged 2 commits into from Nov 29, 2016

Projects

None yet

3 participants

@PVince81
Collaborator

Backport of #25046 to stable9.

Please note that I had to remove one block from the conflict because we don't hate the "X-Requested-With" logic at all in OC 9.0.

Please review @DeepDiver1975 @SergioBertolinSG

I've cherry-picked the automated test from #26712 here

@PVince81 PVince81 added this to the 9.0.7 milestone Nov 25, 2016
@mention-bot

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @SergioBertolinSG and @LukasReschke to be potential reviewers.

@PVince81
Collaborator

Fixes #26720

@PVince81
Collaborator

I retested fed shares in both directions and they still work.

@PVince81
Collaborator

Boo...

error: index-pack died of signal 15
11:07:42 fatal: index-pack failed
DeepDiver1975 and others added some commits Jun 9, 2016
@DeepDiver1975 @PVince81 DeepDiver1975 Use the correct realm for basic authentication - fixes #23427 f418d55
@PVince81 PVince81 Add test for duplicate 401 headers on DAV
505c5c3
@PVince81
Collaborator

@DeepDiver1975 review ? It's your fix that I backported

@@ -26,6 +26,13 @@
namespace OCA\DAV\Connector;
+use Sabre\DAV\Auth\Backend\AbstractBasic;
@DeepDiver1975
DeepDiver1975 Nov 29, 2016 Member

unused - see 36

@DeepDiver1975
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 553448b into stable9 Nov 29, 2016

3 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DeepDiver1975 DeepDiver1975 deleted the stable9-fix-the-realm branch Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment